[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
回复: [PATCH] Fix video playback slowdown when spice client no audio enabl
回复: [PATCH] Fix video playback slowdown when spice client no audio enabled
Sat, 19 Sep 2020 09:41:25 +0000
Sorry for the late reply, I am not working on improve this patch(at least not
now), And you are welcome to send your patches.
发件人: Volker Rümelin <email@example.com>
发送时间: 2020年9月18日 1:22
收件人: zhou qi <firstname.lastname@example.org>
抄送: email@example.com <firstname.lastname@example.org>
主题: Re: [PATCH] Fix video playback slowdown when spice client no audio enabled
> Hello Qi,
> your patch breaks audio playback with the dsoundaudio backend.
> I suggest you make the following changes:
> - Test for size == 0 first and leave the loop in that case.
> - For buf == NULL drop size bytes. Don't leave the loop with break or return.
> - Verify all audio backends adhere to the new rules and fix them if
> necessary. It's quite possible no patches are needed.
> - Rate limit the audio stream in function line_out_get_buffer() in
> audio/spiceaudio.c for the noaudio case too. Have a look at
> audio/spiceaudio.c at version v4.1.0. The code there was correct.
> Please don't forget to run scripts/checkpatch.pl on your next patches and
> don't forget to CC the maintainer.
> With best regards,
I wonder if you are already working on an improved fix. Otherwise I will send
my patches this weekend to the mailing list.
With best regards,