Re: [PATCH 4/4] configure: consistently pass CFLAGS/CXXFLAGS/LDFLAGS to meson

[Richard Henderson]

On 9/20/20 2:30 AM, Paolo Bonzini wrote:
> Environment variables like CFLAGS are easy to accidentally change.  Meson
> warns if that happens, but in a project with a lot of configuration that
> is easy to lose.  It is also surprising behavior since meson caches -D
> options and remembers those on reconfiguration (which we rely on,
> since configure options become -D options).
> 
> By placing the user-provided CFLAGS, CXXFLAGS and LDFLAGS in the
> cross file, we at least get consistent behavior.  These environment
> variables are still ugly and not really recommended, but there are
> distros that rely on them.  For the gory details, refer to
> https://github.com/mesonbuild/meson/issues/4664.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  configure   |  4 ++++
>  meson.build | 14 ++++++++++++--
>  2 files changed, 16 insertions(+), 2 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~