[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 0/8] Configurable policy for handling deprecated interface
From: |
Richard W.M. Jones |
Subject: |
Re: [PATCH v5 0/8] Configurable policy for handling deprecated interfaces |
Date: |
Mon, 21 Sep 2020 13:45:14 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Some general comments on using the patch:
* For libguestfs I chose to add
-compat deprecated-input=reject,deprecated-output=hide
This is only enabled in developer builds of libguestfs when we
are running qemu directly (not via libvirt). The patch for
this is attached.
* What's the point/difference in having reject vs crash?
* I hope that by hiding deprecated QAPI fields we may detect
errors in libguestfs, but I suspect what'll happen is it'll
cause fall-back behaviour which might be harder to detect.
* Be *really* good to have this for command line parameters!
Notes on the attached patch:
* https://libguestfs.org/guestfs-building.1.html
* Simple test:
LIBGUESTFS_BACKEND=direct \
LIBGUESTFS_HV=~/d/qemu/build/x86_64-softmmu/qemu-system-x86_64 \
./run libguestfs-test-tool
* Run the full test suite:
LIBGUESTFS_HV=~/d/qemu/build/x86_64-softmmu/qemu-system-x86_64 \
make -k check-direct
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW
0001-lib-direct-Pass-qemu-compat-to-detect-deprecated-fea.patch
Description: Text document
- Re: [PATCH v5 1/8] qemu-options: New -compat to set policy for deprecated interfaces, (continued)