[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 13/24] i386: Register most CPU properties as class properties
From: |
Eduardo Habkost |
Subject: |
Re: [PATCH 13/24] i386: Register most CPU properties as class properties |
Date: |
Tue, 22 Sep 2020 08:44:17 -0400 |
On Tue, Sep 22, 2020 at 08:41:49AM +0200, Igor Mammedov wrote:
> On Mon, 21 Sep 2020 18:10:34 -0400
> Eduardo Habkost <ehabkost@redhat.com> wrote:
>
> > Class properties make QOM introspection simpler and easier, as
> > they don't require an object to be instantiated.
> >
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> > ---
> > Cc: Paolo Bonzini <pbonzini@redhat.com>
> > Cc: Richard Henderson <rth@twiddle.net>
> > Cc: Eduardo Habkost <ehabkost@redhat.com>
> > Cc: qemu-devel@nongnu.org
> > ---
> > target/i386/cpu.c | 66 ++++++++++++++++++++++++-----------------------
> > 1 file changed, 34 insertions(+), 32 deletions(-)
> >
> > diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> > index 1c58f764dcb..66792f28ba7 100644
> > --- a/target/i386/cpu.c
> > +++ b/target/i386/cpu.c
> > @@ -6922,44 +6922,12 @@ static void x86_cpu_initfn(Object *obj)
> > env->nr_dies = 1;
> > cpu_set_cpustate_pointers(cpu);
> >
> > - object_property_add(obj, "family", "int",
> > - x86_cpuid_version_get_family,
> > - x86_cpuid_version_set_family, NULL, NULL);
> > - object_property_add(obj, "model", "int",
> > - x86_cpuid_version_get_model,
> > - x86_cpuid_version_set_model, NULL, NULL);
> > - object_property_add(obj, "stepping", "int",
> > - x86_cpuid_version_get_stepping,
> > - x86_cpuid_version_set_stepping, NULL, NULL);
> > - object_property_add_str(obj, "vendor",
> > - x86_cpuid_get_vendor,
> > - x86_cpuid_set_vendor);
> > - object_property_add_str(obj, "model-id",
> > - x86_cpuid_get_model_id,
> > - x86_cpuid_set_model_id);
> > - object_property_add(obj, "tsc-frequency", "int",
> > - x86_cpuid_get_tsc_freq,
> > - x86_cpuid_set_tsc_freq, NULL, NULL);
>
>
> > object_property_add(obj, "feature-words", "X86CPUFeatureWordInfo",
> > x86_cpu_get_feature_words,
> > NULL, NULL, (void *)env->features);
> > object_property_add(obj, "filtered-features", "X86CPUFeatureWordInfo",
> > x86_cpu_get_feature_words,
> > NULL, NULL, (void *)cpu->filtered_features);
>
> I'm just curious why these weren't moved as well?
Because of the (void*) arguments that need a pointer to the
instance.
--
Eduardo
- [PATCH 04/24] rng-random: register "filename" as class property, (continued)
- [PATCH 04/24] rng-random: register "filename" as class property, Eduardo Habkost, 2020/09/21
- [PATCH 05/24] vhost-user: Register "chardev" as class property, Eduardo Habkost, 2020/09/21
- [PATCH 06/24] vexpress: Register "secure" as class property, Eduardo Habkost, 2020/09/21
- [PATCH 07/24] rng: Register "opened" as class property, Eduardo Habkost, 2020/09/21
- [PATCH 09/24] input-linux: Register properties as class properties, Eduardo Habkost, 2020/09/21
- [PATCH 08/24] vexpress-a15: Register "virtualization" as class property, Eduardo Habkost, 2020/09/21
- [PATCH 10/24] input-barrier: Register properties as class properties, Eduardo Habkost, 2020/09/21
- [PATCH 11/24] tmp421: Register properties as class properties, Eduardo Habkost, 2020/09/21
- [PATCH 13/24] i386: Register most CPU properties as class properties, Eduardo Habkost, 2020/09/21
- [PATCH 12/24] s390x: Register all CPU properties as class properties, Eduardo Habkost, 2020/09/21
- [PATCH 14/24] i386: Register feature bit properties as class properties, Eduardo Habkost, 2020/09/21
- [PATCH 19/24] xlnx-zcu102: Register properties as class properties, Eduardo Habkost, 2020/09/21
- [PATCH 15/24] arm/virt: Register most properties as class properties, Eduardo Habkost, 2020/09/21