Re: [PATCH 3/8] softfloat: Tidy a * b + inf return

[David Hildenbrand]

On 24.09.20 03:24, Richard Henderson wrote:
> No reason to set values in 'a', when we already
> have float_class_inf in 'c', and can flip that sign.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  fpu/softfloat.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/fpu/softfloat.c b/fpu/softfloat.c
> index 67cfa0fd82..9db55d2b11 100644
> --- a/fpu/softfloat.c
> +++ b/fpu/softfloat.c
> @@ -1380,9 +1380,8 @@ static FloatParts muladd_floats(FloatParts a, 
> FloatParts b, FloatParts c,
>              s->float_exception_flags |= float_flag_invalid;
>              return parts_default_nan(s);
>          } else {
> -            a.cls = float_class_inf;
> -            a.sign = c.sign ^ sign_flip;
> -            return a;
> +            c.sign ^= sign_flip;
> +            return c;
>          }
>      }
>  
> 

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Thanks,

David / dhildenb