[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/4] qemu/bswap: Remove <byteswap.h> dependency
From: |
Peter Maydell |
Subject: |
Re: [PATCH 4/4] qemu/bswap: Remove <byteswap.h> dependency |
Date: |
Thu, 24 Sep 2020 20:33:35 +0100 |
On Thu, 24 Sep 2020 at 20:30, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> On 9/23/20 3:30 AM, Philippe Mathieu-Daudé wrote:
> > On 9/23/20 12:16 PM, Peter Maydell wrote:
> >> I suppose if we wanted to just use the __builtin_bswap*
> >> implementation on all hosts (ie drop the special casing
> >> of CONFIG_MACHINE_BSWAP_H/FreeBSD/Haiku) we'd need to
> >> rename our macros to avoid potential conflicts with the
> >> versions in the system headers there in case they were
> >> pulled in via some other path ?
> >
> > Yes, this is why I couldn't get ride of everything
> >
> > After reading Paolo's suggestion to use qatomic*, I
> > am tempted to suggest qbswap* but I am still looking
> > for better alternatives...
>
> Hum, maybe. It's pretty ugly. We could just leave those alone and hope the
> system version is decent enough.
Mostly what I would like is to be able to be rid of the
configure machinery so we could just use a single
portable implementation.
thanks
-- PMM
- [PATCH 1/4] qemu/bswap: Remove unused qemu_bswap_len(), (continued)
Re: [PATCH 4/4] qemu/bswap: Remove <byteswap.h> dependency, Richard Henderson, 2020/09/24