[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 04/16] qapi/expr.py: Add assertion for union type 'check_dict
|
From: |
Cleber Rosa |
|
Subject: |
Re: [PATCH 04/16] qapi/expr.py: Add assertion for union type 'check_dict' |
|
Date: |
Thu, 24 Sep 2020 20:19:10 -0400 |
On Tue, Sep 22, 2020 at 05:13:01PM -0400, John Snow wrote:
> mypy isn't fond of allowing you to check for bool membership in a
> collection of str elements. Guard this lookup for precisely when we were
> given a name.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
signature.asc
Description: PGP signature
[PATCH 03/16] qapi/expr.py: constrain incoming expression types, John Snow, 2020/09/22
Re: [PATCH 03/16] qapi/expr.py: constrain incoming expression types, Cleber Rosa, 2020/09/24
[PATCH 02/16] qapi/expr.py: Check for dict instead of OrderedDict, John Snow, 2020/09/22
[PATCH 05/16] qapi/expr.py: move string check upwards in check_type, John Snow, 2020/09/22