[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 41/47] qapi/introspect.py: replace 'extra' dict with 'comment'
From: |
John Snow |
Subject: |
[PATCH v3 41/47] qapi/introspect.py: replace 'extra' dict with 'comment' argument |
Date: |
Thu, 24 Sep 2020 20:28:54 -0400 |
This is only used to pass in a dictionary with a comment already set, so
skip the runaround and just accept the comment.
Signed-off-by: John Snow <jsnow@redhat.com>
---
scripts/qapi/introspect.py | 17 ++++++++---------
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/scripts/qapi/introspect.py b/scripts/qapi/introspect.py
index 54bc75393c..c444214090 100644
--- a/scripts/qapi/introspect.py
+++ b/scripts/qapi/introspect.py
@@ -51,12 +51,11 @@
def _make_tree(obj: Union[_DObject, str], ifcond: List[str],
- extra: Optional[Extra] = None
- ) -> AnnotatedNode:
- if extra is None:
- extra = {}
- if ifcond:
- extra['if'] = ifcond
+ comment: Optional[str] = None) -> AnnotatedNode:
+ extra: Extra = {
+ 'if': ifcond,
+ 'comment': comment,
+ }
return (obj, extra)
@@ -199,18 +198,18 @@ def _gen_features(cls,
def _gen_tree(self, name: str, mtype: str, obj: _DObject,
ifcond: List[str],
features: Optional[List[QAPISchemaFeature]]) -> None:
- extra: Extra = None
+ comment: Optional[str] = None
if mtype not in ('command', 'event', 'builtin', 'array'):
if not self._unmask:
# Output a comment to make it easy to map masked names
# back to the source when reading the generated output.
- extra = {'comment': '"%s" = %s' % (self._name(name), name)}
+ comment = f'"{self._name(name)}" = {name}'
name = self._name(name)
obj['name'] = name
obj['meta-type'] = mtype
if features:
obj['features'] = self._gen_features(features)
- self._trees.append(_make_tree(obj, ifcond, extra))
+ self._trees.append(_make_tree(obj, ifcond, comment))
def _gen_member(self,
member: QAPISchemaObjectTypeMember) -> AnnotatedNode:
--
2.26.2
- [PATCH v3 23/47] qapi: establish mypy type-checking baseline, (continued)
- [PATCH v3 23/47] qapi: establish mypy type-checking baseline, John Snow, 2020/09/24
- [PATCH v3 33/47] qapi/gen.py: Enable checking with mypy, John Snow, 2020/09/24
- [PATCH v3 25/47] qapi/events.py: Move comments into docstrings, John Snow, 2020/09/24
- [PATCH v3 16/47] qapi/common.py: Add indent manager, John Snow, 2020/09/24
- [PATCH v3 22/47] qapi/common.py: move build_params into gen.py, John Snow, 2020/09/24
- [PATCH v3 35/47] qapi/gen.py: update write() to be more idiomatic, John Snow, 2020/09/24
- [PATCH v3 27/47] qapi/commands.py: add type hint annotations, John Snow, 2020/09/24
- [PATCH v3 36/47] qapi/gen.py: delint with pylint, John Snow, 2020/09/24
- [PATCH v3 21/47] qapi/common.py: Convert comments into docstrings, and elaborate, John Snow, 2020/09/24
- [PATCH v3 41/47] qapi/introspect.py: replace 'extra' dict with 'comment' argument,
John Snow <=
- [PATCH v3 43/47] qapi/types.py: add type hint annotations, John Snow, 2020/09/24
- [PATCH v3 28/47] qapi/commands.py: enable checking with mypy, John Snow, 2020/09/24
- [PATCH v3 26/47] qapi/commands.py: Don't re-bind to variable of different type, John Snow, 2020/09/24
- [PATCH v3 29/47] qapi/source.py: add type hint annotations, John Snow, 2020/09/24
- [PATCH v3 34/47] qapi/gen.py: Remove unused parameter, John Snow, 2020/09/24
- [PATCH v3 18/47] qapi/common.py: Replace one-letter 'c' variable, John Snow, 2020/09/24
- [PATCH v3 30/47] qapi/source.py: delint with pylint, John Snow, 2020/09/24
- [PATCH v3 37/47] qapi/introspect.py: assert obj is a dict when features are given, John Snow, 2020/09/24
- [PATCH v3 45/47] qapi/visit.py: assert tag_member contains a QAPISchemaEnumType, John Snow, 2020/09/24