[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 00/16] qapi: static typing conversion, pt2
From: |
John Snow |
Subject: |
Re: [PATCH 00/16] qapi: static typing conversion, pt2 |
Date: |
Fri, 25 Sep 2020 18:54:29 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 9/22/20 5:12 PM, John Snow wrote:
based-on: <20200922210101.4081073-1-jsnow@redhat.com>
[PATCH v2 00/38] qapi: static typing conversion, pt1
Hi, this series adds static type hints to the QAPI module.
This is part two!
Part 2: https://gitlab.com/jsnow/qemu/-/tree/python-qapi-cleanup-pt2
Everything: https://gitlab.com/jsnow/qemu/-/tree/python-qapi-cleanup-pt6
Thanks for reviews. I will not be re-spinning pt2 until pt1 is fully
merged, but I have re-based on pt1-v3 and made some minor adjustments to
accommodate new development in pt1.
You can find that staged here:
https://gitlab.com/jsnow/qemu/-/tree/python-qapi-cleanup-pt2
Here's the review status of pt2:
[01] qapi-expr-py-remove-info # [SOB] JS [RB] CR,EH
[02] qapi-expr-py-check-for-dict # [SOB] JS [RB] CR,EH
[03] qapi-expr-py-constrain # [SOB] JS [RB] CR,EH
[04] qapi-expr-py-add-assertion-for # [SOB] JS [RB] CR,EH
[05] qapi-expr-py-move-string-check # [SOB] JS [RB] CR,EH
[06] qapi-expr-py-check-type-of # [SOB] JS [RB] EH
[07] qapi-expr-py-add-casts-in-a # [SOB] JS [RB] CR,EH
[08] qapi-expr-py-add-notational # [SOB] JS [RB] CR,EH
[09] qapi-expr-py-rewrite-check_if # [SOB] JS [RB] CR,EH [TB] CR
[10] qapi-expr-py-remove-single # [SOB] JS [RB] CR,EH
[11] pylint-enable # [SOB] JS [TB] CR,EH [RB] CR,EH
[12] qapi-expr-py-add-docstrings # [SOB] JS [RB] CR
[13] qapi-expr-modify-check_keys-to # [SOB] JS [RB] CR,EH
[14] qapi-expr-use-tuples-instead # [SOB] JS [RB] CR,EH
[15] qapi-expr-move-related-checks # [SOB] JS [RB] CR
[16] qapi-expr-use-an-expression # [SOB] JS [RB] CR,EH
As for the difflog so far:
Patches 2, 3, 7, 8 change import orderings (isort)
Patch 12 sees some docstrings rewritten to pass sphinx.
Patch 15 addresses Eduardo's review comments.
--js
- Re: [PATCH 14/16] qapi/expr.py: Use tuples instead of lists for static data, (continued)
Re: [PATCH 00/16] qapi: static typing conversion, pt2,
John Snow <=