[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 31/47] qapi/gen.py: Fix edge-case of _is_user_module
|
From: |
Cleber Rosa |
|
Subject: |
Re: [PATCH v3 31/47] qapi/gen.py: Fix edge-case of _is_user_module |
|
Date: |
Tue, 29 Sep 2020 00:22:23 -0400 |
On Thu, Sep 24, 2020 at 08:28:44PM -0400, John Snow wrote:
> The edge case is that if the name is '', this expression returns a
> string instead of a bool, which violates our declared type.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
signature.asc
Description: PGP signature
- [PATCH v3 28/47] qapi/commands.py: enable checking with mypy, (continued)
- [PATCH v3 28/47] qapi/commands.py: enable checking with mypy, John Snow, 2020/09/24
- [PATCH v3 26/47] qapi/commands.py: Don't re-bind to variable of different type, John Snow, 2020/09/24
- [PATCH v3 29/47] qapi/source.py: add type hint annotations, John Snow, 2020/09/24
- [PATCH v3 34/47] qapi/gen.py: Remove unused parameter, John Snow, 2020/09/24
- [PATCH v3 18/47] qapi/common.py: Replace one-letter 'c' variable, John Snow, 2020/09/24
- [PATCH v3 30/47] qapi/source.py: delint with pylint, John Snow, 2020/09/24
- [PATCH v3 37/47] qapi/introspect.py: assert obj is a dict when features are given, John Snow, 2020/09/24
- [PATCH v3 45/47] qapi/visit.py: assert tag_member contains a QAPISchemaEnumType, John Snow, 2020/09/24
- [PATCH v3 31/47] qapi/gen.py: Fix edge-case of _is_user_module, John Snow, 2020/09/24
- Re: [PATCH v3 31/47] qapi/gen.py: Fix edge-case of _is_user_module,
Cleber Rosa <=
- [PATCH v3 39/47] qapi/introspect.py: add _gen_features helper, John Snow, 2020/09/24
- [PATCH v3 47/47] qapi/visit.py: add type hint annotations, John Snow, 2020/09/24
- [PATCH v3 42/47] qapi/introspect.py: create a typed 'Node' data structure, John Snow, 2020/09/24
- [PATCH v3 40/47] qapi/introspect.py: Unify return type of _make_tree(), John Snow, 2020/09/24
- [PATCH v3 32/47] qapi/gen.py: add type hint annotations, John Snow, 2020/09/24
- [PATCH v3 38/47] qapi/instrospect.py: add preliminary type hint annotations, John Snow, 2020/09/24
- [PATCH v3 44/47] qapi/types.py: remove one-letter variables, John Snow, 2020/09/24
- [PATCH v3 46/47] qapi/visit.py: remove unused parameters from gen_visit_object, John Snow, 2020/09/24
- Re: [PATCH v3 00/47] qapi: static typing conversion, pt1, John Snow, 2020/09/28