[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gitlab: split deprecated job into build/check stages
From: |
Alex Bennée |
Subject: |
Re: [PATCH] gitlab: split deprecated job into build/check stages |
Date: |
Fri, 02 Oct 2020 12:26:54 +0100 |
User-agent: |
mu4e 1.5.5; emacs 28.0.50 |
Thomas Huth <thuth@redhat.com> writes:
> On 02/10/2020 11.15, Alex Bennée wrote:
>> While the job is pretty fast for only a few targets we still want to
>> catch breakage of the build. By splitting the test step we can
>> allow_failures for that while still ensuring we don't miss the build
>> breaking.
>
> Is there already something broken?
>
> Otherwise, I'd rather simply remove the "allow_failure: true" tag
> instead ... these jobs otherwise tend to get ignored.
Yeah I got a recurring ppc64abi32-linux-user failure as I was testing
the PR.
>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>> .gitlab-ci.yml | 17 ++++++++++++++++-
>> 1 file changed, 16 insertions(+), 1 deletion(-)
>>
>> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>> index 346f23acf7..a51c89554f 100644
>> --- a/.gitlab-ci.yml
>> +++ b/.gitlab-ci.yml
>> @@ -270,9 +270,24 @@ build-deprecated:
>> variables:
>> IMAGE: debian-all-test-cross
>> CONFIGURE_ARGS: --disable-docs --disable-tools
>> - MAKE_CHECK_ARGS: check-tcg
>> + MAKE_CHECK_ARGS: build-tcg
>> TARGETS: ppc64abi32-linux-user tilegx-linux-user lm32-softmmu
>> unicore32-softmmu
>> + artifacts:
>> + expire_in: 2 days
>> + paths:
>> + - build
>> +
>> +# We split the check-tcg step as test failures are expected but we still
>> +# want to catch the build breaking.
>> +check-deprecated:
>> + <<: *native_test_job_definition
>> + needs:
>> + - job: build-deprecated
>> + artifacts: true
>> + variables:
>> + IMAGE: debian-all-test-cross
>> + MAKE_CHECK_ARGS: check-tcg
>
> Anyway, that's better than before, so:
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
--
Alex Bennée