Re: [PATCH] configure: actually disable 'git_update' mode with --disable-git-update

[Daniel P . Berrangé]

On Wed, Sep 30, 2020 at 09:28:54PM -0400, Dan Streetman wrote:
> On Tue, Sep 22, 2020 at 12:34 PM Daniel P. Berrangé <berrange@redhat.com> 
> wrote:
> >
> > On Wed, Jul 29, 2020 at 03:58:29PM -0400, Dan Streetman wrote:
> > > The --disable-git-update configure param sets git_update=no, but
> > > some later checks only look for the .git dir. This changes the
> > > --enable-git-update to set git_update=yes but also fail if it
> > > does not find a .git dir. Then all the later checks for the .git
> > > dir can just be changed to a check for $git_update = "yes".
> > >
> > > Also update the Makefile to skip the 'git_update' checks if it has
> > > been disabled.
> > >
> > > This is needed because downstream packagers, e.g. Debian, Ubuntu, etc,
> > > also keep the source code in git, but do not want to enable the
> > > 'git_update' mode; with the current code, that's not possible even
> > > if the downstream package specifies --disable-git-update.
> >
> > Lets recap the original intended behaviour
> >
> >  1. User building from master qemu.git or a fork
> >      a) git_update=yes (default)
> >          - Always sync submodules to required commit
> >
> >      b) git_update=no  (--disable-git-update)
> >          - Never sync submodules, user is responsible for sync
> >          - Validate submodules are at correct commit and fail if not.
> >
> >  2. User building from tarball
> >      - Never do anything git related at all
> >
> >
> > Your change is removing the validation from  1.b).
> 
> Would you accept adding a --disable-git-submodules-check so downstream
> packagers can keep the source in git, but avoid the submodule
> validation?

It feels like the current option shouldn't be a boolean, rather
a tri-state    --with-git-submodules=[update|validate|ignore]

> Or do you have another suggestion for handling this?

Assuming you're just using git for conveniently applying local
downstream patches, you don't need the git repo to exist once
getting to the build stage. IOW just delete the .git dir after
applying patches before running a build.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|