[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 02/37] tests/check-block: Do not run the iotests with old versions
From: |
Kevin Wolf |
Subject: |
[PULL 02/37] tests/check-block: Do not run the iotests with old versions of bash |
Date: |
Fri, 2 Oct 2020 16:43:10 +0200 |
From: Thomas Huth <thuth@redhat.com>
macOS is shipped with a very old version of the bash (3.2), which
is currently not suitable for running the iotests anymore (e.g.
it is missing support for "readarray" which is used in the file
tests/qemu-iotests/common.filter). Add a check to skip the iotests
in this case - if someone still wants to run the iotests on macOS,
they can install a newer version from homebrew, for example.
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20200918153514.330705-1-thuth@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
tests/check-block.sh | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/tests/check-block.sh b/tests/check-block.sh
index a5a69060e1..f6b1bda7b9 100755
--- a/tests/check-block.sh
+++ b/tests/check-block.sh
@@ -46,6 +46,11 @@ if ! command -v bash >/dev/null 2>&1 ; then
exit 0
fi
+if LANG=C bash --version | grep -q 'GNU bash, version [123]' ; then
+ echo "bash version too old ==> Not running the qemu-iotests."
+ exit 0
+fi
+
if ! (sed --version | grep 'GNU sed') > /dev/null 2>&1 ; then
if ! command -v gsed >/dev/null 2>&1; then
echo "GNU sed not available ==> Not running the qemu-iotests."
--
2.25.4
- [PULL 00/37] Block layer patches, Kevin Wolf, 2020/10/02
- [PULL 01/37] block/sheepdog: Replace magic val by NANOSECONDS_PER_SECOND definition, Kevin Wolf, 2020/10/02
- [PULL 02/37] tests/check-block: Do not run the iotests with old versions of bash,
Kevin Wolf <=
- [PULL 04/37] qemu-io-cmds: Simplify help_oneline, Kevin Wolf, 2020/10/02
- [PULL 03/37] docs: Document the throttle block filter, Kevin Wolf, 2020/10/02
- [PULL 05/37] nbd: Remove unused nbd_export_get_blockdev(), Kevin Wolf, 2020/10/02
- [PULL 08/37] block/export: Add BlockExport infrastructure and block-export-add, Kevin Wolf, 2020/10/02
- [PULL 06/37] qapi: Create block-export module, Kevin Wolf, 2020/10/02
- [PULL 09/37] qemu-storage-daemon: Use qmp_block_export_add(), Kevin Wolf, 2020/10/02
- [PULL 07/37] qapi: Rename BlockExport to BlockExportOptions, Kevin Wolf, 2020/10/02
- [PULL 11/37] block/export: Remove magic from block-export-add, Kevin Wolf, 2020/10/02
- [PULL 10/37] qemu-nbd: Use raw block driver for --offset, Kevin Wolf, 2020/10/02
- [PULL 12/37] nbd: Add max-connections to nbd-server-start, Kevin Wolf, 2020/10/02