[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/5] qapi: Restrict machine (and migration) specific commands
From: |
Markus Armbruster |
Subject: |
Re: [PATCH 0/5] qapi: Restrict machine (and migration) specific commands |
Date: |
Mon, 05 Oct 2020 12:55:14 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 05/10/20 10:01, Markus Armbruster wrote:
>> Philippe Mathieu-Daudé <philmd@redhat.com> writes:
>>
>>> Reduce the machine code pulled into qemu-storage-daemon.
>> I'm leaving review to Eduardo and Marcel for PATCH 1-4, and to David and
>> Juan for PATCH 5. David already ACKed.
>>
>> Can do the pull request.
>>
>
> If it counts, :) for patch 1-4:
>
> Acked-by: Paolo Bonzini <pbonzini@redhat.com>
>
> Generally these patches to remove code from user-mode emulators
> fall into the "if it builds it's fine" bucket, since I assume
> we want the "misc" subschema to be as small as possible.
Moving stuff out of qapi/misc.json is good as long as the new home makes
sense. So, if it builds *and* the maintainers of the new home think it
makes sense to have it there, it's fine.
I don't think we should aim for eliminating every last bit of unused
generated code from every program. We should aim for a sensible split
into sub-modules. Unused generated code in a program can be a sign for
a less than sensible split.
- [PATCH 0/5] qapi: Restrict machine (and migration) specific commands, Philippe Mathieu-Daudé, 2020/10/02
- [PATCH 1/5] qapi: Restrict 'inject-nmi' command to machine code, Philippe Mathieu-Daudé, 2020/10/02
- [PATCH 2/5] qapi: Restrict 'system wakeup/reset/powerdown' commands to machine.json, Philippe Mathieu-Daudé, 2020/10/02
- [PATCH 3/5] qapi: Restrict '(p)memsave' command to machine code, Philippe Mathieu-Daudé, 2020/10/02
- [PATCH 4/5] qapi: Restrict 'query-kvm' command to machine code, Philippe Mathieu-Daudé, 2020/10/02
- [PATCH 5/5] qapi: Restrict Xen migration commands to migration.json, Philippe Mathieu-Daudé, 2020/10/02
- Re: [PATCH 0/5] qapi: Restrict machine (and migration) specific commands, Markus Armbruster, 2020/10/05