[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/1] hw/nvram: Always register FW_CFG_DATA_GENERATOR_INTER
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH v2 1/1] hw/nvram: Always register FW_CFG_DATA_GENERATOR_INTERFACE |
|
Date: |
Tue, 6 Oct 2020 14:20:44 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 06/10/20 14:15, Kevin Wolf wrote:
> Am 06.10.2020 um 13:19 hat Philippe Mathieu-Daudé geschrieben:
>> While the FW_CFG_DATA_GENERATOR_INTERFACE is only consumed
>> by a device only available using system-mode (fw_cfg), it is
>> implemented by a crypto component (tls-cipher-suites) which
>> is always available when crypto is used.
>>
>> Commit 69699f3055 introduced the following error in the
>> qemu-storage-daemon binary:
>>
>> $ echo -e \
>> '{"execute": "qmp_capabilities"}\r\n{"execute":
>> "qom-list-types"}\r\n{"execute": "quit"}\r\n' \
>> | storage-daemon/qemu-storage-daemon --chardev stdio,id=qmp0 --monitor
>> qmp0
>> {"QMP": {"version": {"qemu": {"micro": 50, "minor": 1, "major": 5},
>> "package": ""}, "capabilities": ["oob"]}}
>> {"return": {}}
>> missing interface 'fw_cfg-data-generator' for object 'tls-creds'
>> Aborted (core dumped)
>>
>> Since QOM dependencies are resolved at runtime, this issue
>> could not be triggered at linktime, and we don't have test
>> running the qemu-storage-daemon binary.
>>
>> Fix by always registering the QOM interface.
>>
>> Reported-by: Kevin Wolf <kwolf@redhat.com>
>> Fixes: 69699f3055 ("crypto/tls-cipher-suites: Produce fw_cfg consumable
>> blob")
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> This fails to build for me:
>
> ../hw/nvram/meson.build:2:7: ERROR: Unknown method "add" in object.
It's
Based-on: <20201006111219.2300921-1-philmd@redhat.com>
(which won't be applied in exactly that shape, but more or less it will
be the same).
Paolo