[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 1/6] virtio-mem: Make sure "addr" is always multiples of the b
From: |
David Hildenbrand |
Subject: |
[PATCH v3 1/6] virtio-mem: Make sure "addr" is always multiples of the block size |
Date: |
Thu, 8 Oct 2020 10:30:24 +0200 |
The spec states:
"The device MUST set addr, region_size, usable_region_size, plugged_size,
requested_size to multiples of block_size."
In some cases, we currently don't guarantee that for "addr": For example,
when starting a VM with 4 GiB boot memory and a virtio-mem device with a
block size of 2 GiB, "memaddr"/"addr" will be auto-assigned to
0x140000000 (5 GiB).
We'll try to improve auto-assignment for memory devices next, to avoid
bailing out in case memory device code selects a bad address.
Note: The Linux driver doesn't support such big block sizes yet.
Reviewed-by: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
Fixes: 910b25766b33 ("virtio-mem: Paravirtualized memory hot(un)plug")
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Wei Yang <richardw.yang@linux.intel.com>
Cc: Dr. David Alan Gilbert <dgilbert@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>
Cc: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
hw/virtio/virtio-mem.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/hw/virtio/virtio-mem.c b/hw/virtio/virtio-mem.c
index 7c8ca9f28b..70200b4eac 100644
--- a/hw/virtio/virtio-mem.c
+++ b/hw/virtio/virtio-mem.c
@@ -449,6 +449,11 @@ static void virtio_mem_device_realize(DeviceState *dev,
Error **errp)
")", VIRTIO_MEM_REQUESTED_SIZE_PROP,
VIRTIO_MEM_BLOCK_SIZE_PROP, vmem->block_size);
return;
+ } else if (!QEMU_IS_ALIGNED(vmem->addr, vmem->block_size)) {
+ error_setg(errp, "'%s' property has to be multiples of '%s' (0x%"
PRIx64
+ ")", VIRTIO_MEM_ADDR_PROP, VIRTIO_MEM_BLOCK_SIZE_PROP,
+ vmem->block_size);
+ return;
} else if (!QEMU_IS_ALIGNED(memory_region_size(&vmem->memdev->mr),
vmem->block_size)) {
error_setg(errp, "'%s' property memdev size has to be multiples of"
--
2.26.2
- [PATCH v3 0/6] virtio-mem: block size and address-assignment optimizations, David Hildenbrand, 2020/10/08
- [PATCH v3 1/6] virtio-mem: Make sure "addr" is always multiples of the block size,
David Hildenbrand <=
- [PATCH v3 2/6] virtio-mem: Make sure "usable_region_size" is always multiples of the block size, David Hildenbrand, 2020/10/08
- [PATCH v3 3/6] virtio-mem: Probe THP size to determine default block size, David Hildenbrand, 2020/10/08
- [PATCH v3 4/6] memory-device: Support big alignment requirements, David Hildenbrand, 2020/10/08
- [PATCH v3 5/6] memory-device: Add get_min_alignment() callback, David Hildenbrand, 2020/10/08
- [PATCH v3 6/6] virito-mem: Implement get_min_alignment(), David Hildenbrand, 2020/10/08
- Re: [PATCH v3 0/6] virtio-mem: block size and address-assignment optimizations, David Hildenbrand, 2020/10/22