[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 05/11] tests/qtest/qos-test: dump environment variables if
From: |
Paolo Bonzini |
Subject: |
Re: [PATCH v3 05/11] tests/qtest/qos-test: dump environment variables if verbose |
Date: |
Thu, 8 Oct 2020 14:37:00 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 02/10/20 18:15, Christian Schoenebeck wrote:
> -int main(int argc, char **argv)
> +int main(int argc, char **argv, char** envp)
> {
> g_test_init(&argc, &argv, NULL);
> + if (g_test_verbose()) {
> + printf("ENVIRONMENT VARIABLES: {\n");
> + for (char **env = envp; *env != 0; env++) {
> + printf("\t%s\n", *env);
> + }
> + printf("}\n");
> + }
But doesn't this (and patch 6 as well) break TAP output? Using
g_test_message + g_test_verbose would be the best of both worlds.
In fact using printf in tests should be forbidden, since glib 2.62 and
newer _always_ emit TAP.
Paolo
- [PATCH v3 11/11] tests/9pfs: add local Tmkdir test, (continued)
- [PATCH v3 11/11] tests/9pfs: add local Tmkdir test, Christian Schoenebeck, 2020/10/02
- [PATCH v3 10/11] tests/9pfs: add virtio_9p_test_path(), Christian Schoenebeck, 2020/10/02
- [PATCH v3 09/11] tests/9pfs: wipe local 9pfs test directory, Christian Schoenebeck, 2020/10/02
- [PATCH v3 04/11] tests/qtest/qos-test: dump qos graph if verbose, Christian Schoenebeck, 2020/10/02
- [PATCH v3 07/11] tests/9pfs: change qtest name prefix to synth, Christian Schoenebeck, 2020/10/02
- [PATCH v3 02/11] libqos/qgraph: add qos_node_create_driver_named(), Christian Schoenebeck, 2020/10/02
- [PATCH v3 03/11] libqos/qgraph: add qos_dump_graph(), Christian Schoenebeck, 2020/10/02
- [PATCH v3 05/11] tests/qtest/qos-test: dump environment variables if verbose, Christian Schoenebeck, 2020/10/02
- Re: [PATCH v3 05/11] tests/qtest/qos-test: dump environment variables if verbose,
Paolo Bonzini <=
- Re: [PATCH v3 05/11] tests/qtest/qos-test: dump environment variables if verbose, Christian Schoenebeck, 2020/10/08
- Re: [PATCH v3 05/11] tests/qtest/qos-test: dump environment variables if verbose, Paolo Bonzini, 2020/10/08
- Re: [PATCH v3 05/11] tests/qtest/qos-test: dump environment variables if verbose, Christian Schoenebeck, 2020/10/08
- Re: [PATCH v3 05/11] tests/qtest/qos-test: dump environment variables if verbose, Paolo Bonzini, 2020/10/08
- Re: [PATCH v3 05/11] tests/qtest/qos-test: dump environment variables if verbose, Christian Schoenebeck, 2020/10/08
[PATCH v3 08/11] tests/9pfs: introduce local tests, Christian Schoenebeck, 2020/10/02
[PATCH v3 01/11] libqos/qgraph: add qemu_name to QOSGraphNode, Christian Schoenebeck, 2020/10/02