[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 09/10] migration/dirtyrate: record start_time and calc_time while
From: |
Dr. David Alan Gilbert (git) |
Subject: |
[PULL 09/10] migration/dirtyrate: record start_time and calc_time while at the measuring state |
Date: |
Thu, 8 Oct 2020 20:10:45 +0100 |
From: Chuan Zheng <zhengchuan@huawei.com>
Querying could include both the start-time and the calc-time while at the
measuring
state, allowing a caller to determine when they should expect to come back
looking
for a result.
Signed-off-by: Chuan Zheng <zhengchuan@huawei.com>
Message-Id: <1601350938-128320-2-git-send-email-zhengchuan@huawei.com>
Reviewed-by: David Edmondson <david.edmondson@oracle.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
migration/dirtyrate.c | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c
index 68577ef250..40e41e793e 100644
--- a/migration/dirtyrate.c
+++ b/migration/dirtyrate.c
@@ -83,14 +83,14 @@ static struct DirtyRateInfo *query_dirty_rate_info(void)
return info;
}
-static void reset_dirtyrate_stat(void)
+static void init_dirtyrate_stat(int64_t start_time, int64_t calc_time)
{
DirtyStat.total_dirty_samples = 0;
DirtyStat.total_sample_count = 0;
DirtyStat.total_block_mem_MB = 0;
DirtyStat.dirty_rate = -1;
- DirtyStat.start_time = 0;
- DirtyStat.calc_time = 0;
+ DirtyStat.start_time = start_time;
+ DirtyStat.calc_time = calc_time;
}
static void update_dirtyrate_stat(struct RamblockDirtyInfo *info)
@@ -335,7 +335,6 @@ static void calculate_dirtyrate(struct DirtyRateConfig
config)
int64_t initial_time;
rcu_register_thread();
- reset_dirtyrate_stat();
rcu_read_lock();
initial_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME);
if (!record_ramblock_hash_info(&block_dinfo, config, &block_count)) {
@@ -365,6 +364,8 @@ void *get_dirtyrate_thread(void *arg)
{
struct DirtyRateConfig config = *(struct DirtyRateConfig *)arg;
int ret;
+ int64_t start_time;
+ int64_t calc_time;
ret = dirtyrate_set_state(&CalculatingState, DIRTY_RATE_STATUS_UNSTARTED,
DIRTY_RATE_STATUS_MEASURING);
@@ -373,6 +374,10 @@ void *get_dirtyrate_thread(void *arg)
return NULL;
}
+ start_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME) / 1000;
+ calc_time = config.sample_period_seconds;
+ init_dirtyrate_stat(start_time, calc_time);
+
calculate_dirtyrate(config);
ret = dirtyrate_set_state(&CalculatingState, DIRTY_RATE_STATUS_MEASURING,
--
2.28.0
- Re: [PULL 00/10] migration queue, (continued)
- [PULL 00/10] migration queue, Dr. David Alan Gilbert (git), 2020/10/08
- [PULL 01/10] virtiofsd: Silence gcc warning, Dr. David Alan Gilbert (git), 2020/10/08
- [PULL 02/10] tools/virtiofsd: add support for --socket-group, Dr. David Alan Gilbert (git), 2020/10/08
- [PULL 03/10] virtiofsd: Call qemu_init_exec_dir, Dr. David Alan Gilbert (git), 2020/10/08
- [PULL 04/10] virtiofsd: avoid /proc/self/fd tempdir, Dr. David Alan Gilbert (git), 2020/10/08
- [PULL 05/10] migration: Pass incoming state into qemu_ufd_copy_ioctl(), Dr. David Alan Gilbert (git), 2020/10/08
- [PULL 06/10] migration: Introduce migrate_send_rp_message_req_pages(), Dr. David Alan Gilbert (git), 2020/10/08
- [PULL 07/10] migration: Maintain postcopy faulted addresses, Dr. David Alan Gilbert (git), 2020/10/08
- [PULL 08/10] migration: Sync requested pages after postcopy recovery, Dr. David Alan Gilbert (git), 2020/10/08
- [PULL 09/10] migration/dirtyrate: record start_time and calc_time while at the measuring state,
Dr. David Alan Gilbert (git) <=
- [PULL 10/10] migration/dirtyrate: present dirty rate only when querying the rate has completed, Dr. David Alan Gilbert (git), 2020/10/08
- Re: [PULL 00/10] migration queue, Peter Maydell, 2020/10/11