qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC v1 0/4] unbreak non-tcg builds


From: no-reply
Subject: Re: [RFC v1 0/4] unbreak non-tcg builds
Date: Fri, 9 Oct 2020 08:30:48 -0700 (PDT)

Patchew URL: 20201009152108.16120-1-cfontana@suse.de/">https://patchew.org/QEMU/20201009152108.16120-1-cfontana@suse.de/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20201009152108.16120-1-cfontana@suse.de
Subject: [RFC v1 0/4] unbreak non-tcg builds

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   b7092cd..e1c30c4  master     -> master
 - [tag update]      patchew/20200930003033.554124-1-laurent@vivier.eu -> 
patchew/20200930003033.554124-1-laurent@vivier.eu
 - [tag update]      patchew/20201008202713.1416823-1-ehabkost@redhat.com -> 
patchew/20201008202713.1416823-1-ehabkost@redhat.com
 * [new tag]         patchew/20201009152108.16120-1-cfontana@suse.de -> 
patchew/20201009152108.16120-1-cfontana@suse.de
 - [tag update]      
patchew/8f07132478469b35fb50a4706691e2b56b10a67b.camel@gmail.com -> 
patchew/8f07132478469b35fb50a4706691e2b56b10a67b.camel@gmail.com
Switched to a new branch 'test'
2ca7ef6 replay: do not build if TCG is not available
8d5176b qtest: do not build ide-test if TCG is not available
2c8768d qtest: unbreak non-TCG builds in bios-tables-test
93bdf53 tests/Makefile.include: unbreak non-tcg builds

=== OUTPUT BEGIN ===
1/4 Checking commit 93bdf53ce1d2 (tests/Makefile.include: unbreak non-tcg 
builds)
ERROR: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 8 lines checked

Patch 1/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/4 Checking commit 2c8768d98a82 (qtest: unbreak non-TCG builds in 
bios-tables-test)
3/4 Checking commit 8d5176ba88fb (qtest: do not build ide-test if TCG is not 
available)
4/4 Checking commit 2ca7ef6b4d8e (replay: do not build if TCG is not available)
ERROR: Error messages should not contain newlines
#130: FILE: stubs/replay.c:174:
+    error_report("replay support not available\n");

ERROR: Error messages should not contain newlines
#134: FILE: stubs/replay.c:178:
+    error_report("replay support not available\n");

ERROR: Error messages should not contain newlines
#138: FILE: stubs/replay.c:182:
+    error_report("replay support not available\n");

ERROR: Error messages should not contain newlines
#142: FILE: stubs/replay.c:186:
+    error_report("replay support not available\n");

WARNING: line over 80 characters
#146: FILE: stubs/replay.c:190:
+    error_set(errp, ERROR_CLASS_COMMAND_NOT_FOUND, "replay support not 
available");

WARNING: line over 80 characters
#151: FILE: stubs/replay.c:195:
+    error_set(errp, ERROR_CLASS_COMMAND_NOT_FOUND, "replay support not 
available");

WARNING: line over 80 characters
#155: FILE: stubs/replay.c:199:
+    error_set(errp, ERROR_CLASS_COMMAND_NOT_FOUND, "replay support not 
available");

WARNING: line over 80 characters
#159: FILE: stubs/replay.c:203:
+    error_set(errp, ERROR_CLASS_COMMAND_NOT_FOUND, "replay support not 
available");

total: 4 errors, 4 warnings, 139 lines checked

Patch 4/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20201009152108.16120-1-cfontana@suse.de/testing.checkpatch/?type=message">http://patchew.org/logs/20201009152108.16120-1-cfontana@suse.de/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

reply via email to

[Prev in Thread] Current Thread [Next in Thread]