qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] vmbus: Don't make QOM property registration conditional


From: Eduardo Habkost
Subject: Re: [PATCH] vmbus: Don't make QOM property registration conditional
Date: Fri, 9 Oct 2020 17:33:36 -0400

On Fri, Oct 09, 2020 at 11:05:47PM +0200, Maciej S. Szmigiero wrote:
> On 09.10.2020 22:07, Eduardo Habkost wrote:
> > Having properties registered conditionally makes QOM type
> > introspection difficult.  Instead of skipping registration of the
> > "instanceid" property, always register the property but validate
> > its value against the instance id required by the class.
> > 
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> > ---
> > Note: due to the lack of concrete vmbus-dev subclasses in the
> > QEMU tree, this patch couldn't be tested.
> 
> Will test it tomorrow since I have a VMBus device implementation.

Thanks!

Is anybody willing to volunteer to be listed as maintainer (or
reviewer, at least) of hw/hyperv/vmbus.c?

-- 
Eduardo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]