[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 3/3] replay: do not build if TCG is not available

From: Paolo Bonzini
Subject: Re: [PATCH v2 3/3] replay: do not build if TCG is not available
Date: Tue, 13 Oct 2020 00:29:17 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0

On 12/10/20 23:45, Claudio Fontana wrote:
> +    ctx = blk_get_aio_context(blk);
> +    if (!replay_bh_schedule_oneshot_event(ctx, error_callback_bh, acb)) {
> +        /* regular case without replay */
> +        aio_bh_schedule_oneshot(ctx, error_callback_bh, acb);
> +    }

Why can't the stub just call aio_bh_schedule_oneshot?  This makes the
API even more complicated.

I think you are doing this in order to avoid link errors in tools, but
it's not necessary. you can have more than one stub file:

- replay/replay-stub.c for functions needed by emulators (added with
"if_false:", it also includes the monitor commands);

- stubs/replay.c for functions needed by tools (including
replay_bh_schedule_oneshot_event which is currently in
stubs/replay-user.c for some reason).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]