[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 22/23] scripts/ci/gitlab-pipeline-status: use more descriptive exc
From: |
Thomas Huth |
Subject: |
[PULL 22/23] scripts/ci/gitlab-pipeline-status: use more descriptive exceptions |
Date: |
Tue, 13 Oct 2020 12:55:26 +0200 |
From: Cleber Rosa <crosa@redhat.com>
For two very different error conditions.
Signed-off-by: Cleber Rosa <crosa@redhat.com>
Message-Id: <20200904164258.240278-7-crosa@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
scripts/ci/gitlab-pipeline-status | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/scripts/ci/gitlab-pipeline-status
b/scripts/ci/gitlab-pipeline-status
index ced488f27c..628150ce0b 100755
--- a/scripts/ci/gitlab-pipeline-status
+++ b/scripts/ci/gitlab-pipeline-status
@@ -23,6 +23,14 @@ import time
import sys
+class CommunicationFailure(Exception):
+ """Failed to communicate to gitlab.com APIs."""
+
+
+class NoPipelineFound(Exception):
+ """Communication is successfull but pipeline is not found."""
+
+
def get_local_branch_commit(branch='staging'):
"""
Returns the commit sha1 for the *local* branch named "staging"
@@ -50,14 +58,14 @@ def get_pipeline_status(project_id, commit_sha1):
connection.request('GET', url=url)
response = connection.getresponse()
if response.code != http.HTTPStatus.OK:
- raise ValueError("Failed to receive a successful response")
+ raise CommunicationFailure("Failed to receive a successful response")
json_response = json.loads(response.read())
# As far as I can tell, there should be only one pipeline for the same
# project + commit. If this assumption is false, we can add further
# filters to the url, such as username, and order_by.
if not json_response:
- raise ValueError("No pipeline found")
+ raise NoPipelineFound("No pipeline found")
return json_response[0]
--
2.18.2
- [PULL 15/23] gitlab: add a CI job to validate the DCO sign off, (continued)
- [PULL 15/23] gitlab: add a CI job to validate the DCO sign off, Thomas Huth, 2020/10/13
- [PULL 07/23] tests/migration: Allow longer timeouts, Thomas Huth, 2020/10/13
- [PULL 14/23] gitlab: add a CI job for running checkpatch.pl, Thomas Huth, 2020/10/13
- [PULL 16/23] gitlab: assign python helper files to GitLab maintainers section, Thomas Huth, 2020/10/13
- [PULL 18/23] scripts/ci/gitlab-pipeline-status: improve message regarding timeout, Thomas Huth, 2020/10/13
- [PULL 17/23] scripts/ci/gitlab-pipeline-status: make branch name configurable, Thomas Huth, 2020/10/13
- [PULL 20/23] scripts/ci/gitlab-pipeline-status: refactor parser creation, Thomas Huth, 2020/10/13
- [PULL 21/23] scripts/ci/gitlab-pipeline-status: handle keyboard interrupts, Thomas Huth, 2020/10/13
- [PULL 19/23] scripts/ci/gitlab-pipeline-status: give early feedback on running pipelines, Thomas Huth, 2020/10/13
- [PULL 23/23] scripts/ci/gitlab-pipeline-status: wait for pipeline creation, Thomas Huth, 2020/10/13
- [PULL 22/23] scripts/ci/gitlab-pipeline-status: use more descriptive exceptions,
Thomas Huth <=
- Re: [PULL 00/23] qtests, gitlab-CI and misc patches, Peter Maydell, 2020/10/13