[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 06/10] coroutine: add libucontext as external library
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH 06/10] coroutine: add libucontext as external library |
Date: |
Tue, 13 Oct 2020 14:31:35 +0100 |
On Mon, Oct 12, 2020 at 04:29:35PM -0700, Joelle van Dyne wrote:
> From: osy <osy86@users.noreply.github.com>
>
> iOS does not support ucontext natively for aarch64 and the sigaltstack is
> also unsupported (even worse, it fails silently, see:
> https://openradar.appspot.com/13002712 )
>
> As a workaround we include a library implementation of ucontext and add it
> as a build option.
>
> Signed-off-by: Joelle van Dyne <j@getutm.app>
Hi,
Thanks for sending posting this!
Please indicate what license libucontext is under, that it is compatible
with QEMU's overall GPL v2 license, and update QEMU license
documentation (LICENSE, etc), if necessary.
Please update .gitlab-ci.yml with build tests. Is there a way to test
building QEMU for iOS? If not, then it's difficult for the upstream QEMU
project to carry iOS-specific features since we cannot test them.
Thanks,
Stefan
signature.asc
Description: PGP signature
[PATCH 05/10] slirp: update for iOS resolv fix, Joelle van Dyne, 2020/10/12
[PATCH 07/10] tcg: implement bulletproof JIT, Joelle van Dyne, 2020/10/12