[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/7] dockerfiles: enable Centos 8 PowerTools
From: |
Paolo Bonzini |
Subject: |
Re: [PATCH 5/7] dockerfiles: enable Centos 8 PowerTools |
Date: |
Thu, 15 Oct 2020 08:36:26 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 14/10/20 22:49, Cleber Rosa wrote:
> On Wed, Oct 14, 2020 at 09:54:14AM -0400, Paolo Bonzini wrote:
>> ninja is included in the CentOS PowerTools repository.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>> tests/docker/dockerfiles/centos8.docker | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/tests/docker/dockerfiles/centos8.docker
>> b/tests/docker/dockerfiles/centos8.docker
>> index 0fc2697491..e31d366fc1 100644
>> --- a/tests/docker/dockerfiles/centos8.docker
>> +++ b/tests/docker/dockerfiles/centos8.docker
>> @@ -1,6 +1,9 @@
>> FROM centos:8.1.1911
>>
>> +RUN dnf -y install dnf-plugins-core
>> +RUN dnf config-manager --set-enabled PowerTools
>
> Since config-manager won't be used besides here, I think it's safe and
> cheaper to simply do:
>
> RUN sed -i /etc/yum.repos.d/CentOS-PowerTools.repo -e
> 's/^enabled=0/enabled=1/'
>
> It's also a single command, reducing the number of layers.
Yeah, I'm lazy. :) I'll use Dan's suggestion.
Paolo
- [PATCH 0/7] build: replace ninjatool with ninja, Paolo Bonzini, 2020/10/14
- [PATCH 1/7] tests/Makefile.include: unbreak non-tcg builds, Paolo Bonzini, 2020/10/14
- [PATCH 2/7] make: run shell with pipefail, Paolo Bonzini, 2020/10/14
- [PATCH 3/7] tests: add missing generated sources to testqapi, Paolo Bonzini, 2020/10/14
- [PATCH 5/7] dockerfiles: enable Centos 8 PowerTools, Paolo Bonzini, 2020/10/14
- [PATCH 4/7] configure: move QEMU_INCLUDES to meson, Paolo Bonzini, 2020/10/14
- [PATCH 6/7] add ninja to dockerfiles, CI configurations and test VMs, Paolo Bonzini, 2020/10/14
- [PATCH 7/7] build: replace ninjatool with ninja, Paolo Bonzini, 2020/10/14
- Re: [PATCH 0/7] build: replace ninjatool with ninja, Peter Maydell, 2020/10/14
- Re: [PATCH 0/7] build: replace ninjatool with ninja, Howard Spoelstra, 2020/10/15