[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 02/10] test-keyval: Demonstrate misparse of ', ' with implied key
From: |
Kevin Wolf |
Subject: |
[PULL 02/10] test-keyval: Demonstrate misparse of ', ' with implied key |
Date: |
Thu, 15 Oct 2020 16:49:44 +0200 |
From: Markus Armbruster <armbru@redhat.com>
Add a test for "val,,ue" with implied key. Documentation says this
should parse as implied key with value "val", then fail. The code
parses it as implied key with value "val,ue", then succeeds. The next
commit will fix it.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20201011073505.1185335-3-armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
tests/test-keyval.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/tests/test-keyval.c b/tests/test-keyval.c
index e331a84149..f02bdf7029 100644
--- a/tests/test-keyval.c
+++ b/tests/test-keyval.c
@@ -182,6 +182,13 @@ static void test_keyval_parse(void)
error_free_or_abort(&err);
g_assert(!qdict);
+ /* Implied key's value can't have comma (qemu_opts_parse(): it can) */
+ /* BUG: it can */
+ qdict = keyval_parse("val,,ue", "implied", &error_abort);
+ g_assert_cmpuint(qdict_size(qdict), ==, 1);
+ g_assert_cmpstr(qdict_get_try_str(qdict, "implied"), ==, "val,ue");
+ qobject_unref(qdict);
+
/* Empty key is not an implied key */
qdict = keyval_parse("=val", "implied", &err);
error_free_or_abort(&err);
--
2.28.0
- [PULL 00/10] Block layer patches, Kevin Wolf, 2020/10/15
- [PULL 01/10] keyval: Fix and clarify grammar, Kevin Wolf, 2020/10/15
- [PULL 02/10] test-keyval: Demonstrate misparse of ', ' with implied key,
Kevin Wolf <=
- [PULL 03/10] keyval: Fix parsing of ',' in value of implied key, Kevin Wolf, 2020/10/15
- [PULL 05/10] qom: Factor out helpers from user_creatable_print_help(), Kevin Wolf, 2020/10/15
- [PULL 06/10] qom: Add user_creatable_print_help_from_qdict(), Kevin Wolf, 2020/10/15
- [PULL 09/10] block: drop moderated sheepdog mailing list from MAINTAINERS file, Kevin Wolf, 2020/10/15
- [PULL 04/10] keyval: Parse help options, Kevin Wolf, 2020/10/15
- [PULL 07/10] qemu-storage-daemon: Remove QemuOpts from --object parser, Kevin Wolf, 2020/10/15
- [PULL 08/10] monitor: Fix order in monitor_cleanup(), Kevin Wolf, 2020/10/15
- [PULL 10/10] block: deprecate the sheepdog block driver, Kevin Wolf, 2020/10/15
- Re: [PULL 00/10] Block layer patches, Peter Maydell, 2020/10/16