[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/3] grackle: use qdev gpios for PCI IRQs

From: BALATON Zoltan
Subject: Re: [PATCH v2 2/3] grackle: use qdev gpios for PCI IRQs
Date: Fri, 16 Oct 2020 02:26:24 +0200 (CEST)

On Thu, 15 Oct 2020, Mark Cave-Ayland wrote:
I've queued the grackle/uninorth patches to my qemu-macppc branch, however when I try to apply patches from the above series git fails with the following message:

Applying: mac_oldworld: Drop a variable, use get_system_memory() directly
error: sha1 information is lacking or useless (hw/ppc/mac_oldworld.c).
error: could not build fake ancestor

Maybe because these were based on your screamer branch but I could cherry-pick them from there to your qemu-macppc branch without issue.

Any chance you can rebase and repost? I'm happy to take patches 3 and 4, and

I've just posted the rebased series.

if my suggestion of casting the return address via target_ulong works then I think 1 and 2 are also fine.

Your original comment was:

"Given that this needs to work with both qemu-system-ppc and qemu-system-ppc64 would casting bios_addr to target_ulong work?"

This cast only appears in mac_oldworld.c which is qemu-system-ppc only (or not different in qemu-system-ppc64 unlike mac_newworld.c) so target_ulong there is basically uint32_t. I've changed the cast accordingly but I think it does not really matter.

The I2C stuff I can't really review, and weren't there still issues with the SPD data in patch 8 reporting the wrong RAM size?

As said in previous message the i2c and SPD patches are not quite ready yet so I've omitted those from this series, I may rework them later once this part is merged and can rebase the rest on top of that. We would also need your screamer patches to get the Mac ROM working, what is still missing for those?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]