|
From: | Mark Cave-Ayland |
Subject: | Re: [PATCH v2 0/2] hw/rtc/m48t59: Simplify m48t59_init() |
Date: | Fri, 16 Oct 2020 10:38:47 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 |
On 15/10/2020 20:46, Philippe Mathieu-Daudé wrote:
Since v1: - Do not remove mem_base in patch 1 (Laurent) - Pass MemoryRegion* (new patch) - Run check-qtest Philippe Mathieu-Daudé (2): hw/rtc/m48t59: Simplify m48t59_init() removing 'io_base' argument hw/rtc/m48t59: Simplify m48t59_init() passing MemoryRegion argument include/hw/rtc/m48t59.h | 5 ++--- hw/ppc/ppc405_boards.c | 2 +- hw/rtc/m48t59.c | 14 +++----------- hw/sparc/sun4m.c | 3 ++- hw/sparc64/sun4u.c | 7 ++----- 5 files changed, 10 insertions(+), 21 deletions(-)
This looks good, and from what you've done here it's only a little more work to remove m48t59_init() completely. Would you mind if I try this using these patches as a starting point? :)
ATB, Mark.
[Prev in Thread] | Current Thread | [Next in Thread] |