[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 07/37] cpus: extract out hax-specific code to target/i386/
From: |
Volker Rümelin |
Subject: |
Re: [PULL 07/37] cpus: extract out hax-specific code to target/i386/ |
Date: |
Sat, 17 Oct 2020 09:17:54 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.2 |
>> Hi Claudio,
>>
>> is there a reason why you removed current_cpu = cpu; from
>> hax_cpu_thread_fn() when you moved that function to target/i386/hax-cpus.c?
>> This change broke HAX on Windows. Adding back that line makes it work again.
>
> Hello Volker, I see the change in the history and it was clearly an ugly
> mistake on my part.
> There was no reason or intention to remove the current_cpu = cpu assignment
>
> The fix seems indeed to just + current_cpu = cpu;
> and I will send a patch momentarily that does just that,
>
> but I don't know of any CI coverage for Windows + hax currently,
> so it would be good if you could spin the change to verify that it fixes the
> problem.
>
That was very quick. Only 5 hours from bug report to pull request. I've tested
current master together with the patch from Paolo's PR. HAX on Windows works.
With best regards,
Volker
- [PULL 00/37] Build system + accel + record/replay patches for 2020-10-06, Paolo Bonzini, 2020/10/06
- [PULL 02/37] icount: rename functions to be consistent with the module name, Paolo Bonzini, 2020/10/06
- [PULL 03/37] cpus: prepare new CpusAccel cpu accelerator interface, Paolo Bonzini, 2020/10/06
- [PULL 05/37] cpus: extract out qtest-specific code to accel/qtest, Paolo Bonzini, 2020/10/06
- [PULL 01/37] cpu-timers, icount: new modules, Paolo Bonzini, 2020/10/06
- [PULL 04/37] cpus: extract out TCG-specific code to accel/tcg, Paolo Bonzini, 2020/10/06
- [PULL 07/37] cpus: extract out hax-specific code to target/i386/, Paolo Bonzini, 2020/10/06
- [PULL 06/37] cpus: extract out kvm-specific code to accel/kvm, Paolo Bonzini, 2020/10/06
- [PULL 08/37] cpus: extract out whpx-specific code to target/i386/, Paolo Bonzini, 2020/10/06
- [PULL 10/37] cpus: cleanup now unneeded includes, Paolo Bonzini, 2020/10/06
- [PULL 09/37] cpus: extract out hvf-specific code to target/i386/hvf/, Paolo Bonzini, 2020/10/06
- [PULL 12/37] cpus: add handle_interrupt to the CpusAccel interface, Paolo Bonzini, 2020/10/06
- [PULL 13/37] hvf: remove hvf specific functions from global includes, Paolo Bonzini, 2020/10/06
- [PULL 15/37] hax: remove hax specific functions from global includes, Paolo Bonzini, 2020/10/06
- [PULL 11/37] cpus: remove checks for non-NULL cpus_accel, Paolo Bonzini, 2020/10/06
- [PULL 14/37] whpx: remove whpx specific functions from global includes, Paolo Bonzini, 2020/10/06
- [PULL 16/37] kvm: remove kvm specific functions from global includes, Paolo Bonzini, 2020/10/06