Re: [PATCH] qemu-img: add support for offline rate limit in qemu-img commit

[no-reply]

Patchew URL: 
1602999097-24744-1-git-send-email-lizhengui@huawei.com/">https://patchew.org/QEMU/1602999097-24744-1-git-send-email-lizhengui@huawei.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1602999097-24744-1-git-send-email-lizhengui@huawei.com
Subject: [PATCH] qemu-img: add support for offline rate limit in qemu-img commit

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         
patchew/1602999097-24744-1-git-send-email-lizhengui@huawei.com -> 
patchew/1602999097-24744-1-git-send-email-lizhengui@huawei.com
Switched to a new branch 'test'
ffdac92 qemu-img: add support for offline rate limit in qemu-img commit

=== OUTPUT BEGIN ===
ERROR: consider using qemu_strtoull in preference to strtoull
#59: FILE: qemu-img.c:1032:
+            unsigned long long sval = strtoull(optarg, &end, 10);

total: 1 errors, 0 warnings, 49 lines checked

Commit ffdac92f0f39 (qemu-img: add support for offline rate limit in qemu-img 
commit) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
1602999097-24744-1-git-send-email-lizhengui@huawei.com/testing.checkpatch/?type=message">http://patchew.org/logs/1602999097-24744-1-git-send-email-lizhengui@huawei.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com