[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] microbit_i2c: Fix coredump when dump-vmstate

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH] microbit_i2c: Fix coredump when dump-vmstate
Date: Mon, 19 Oct 2020 12:35:04 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1

On 10/19/20 11:34 AM, Peng Liang wrote:
VMStateDescription.fields should be end with VMSTATE_END_OF_LIST().
However, microbit_i2c_vmstate doesn't follow it.  Let's change it.

It might be easy to add a Coccinelle script to avoid future errors.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Fixes: 9d68bf564e ("arm: Stub out NRF51 TWI magnetometer/accelerometer 
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Peng Liang <liangpeng10@huawei.com>
  hw/i2c/microbit_i2c.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/hw/i2c/microbit_i2c.c b/hw/i2c/microbit_i2c.c
index 802473982082..e92f9f84ea81 100644
--- a/hw/i2c/microbit_i2c.c
+++ b/hw/i2c/microbit_i2c.c
@@ -83,6 +83,7 @@ static const VMStateDescription microbit_i2c_vmstate = {
      .fields = (VMStateField[]) {
          VMSTATE_UINT32_ARRAY(regs, MicrobitI2CState, MICROBIT_I2C_NREGS),
          VMSTATE_UINT32(read_idx, MicrobitI2CState),

reply via email to

[Prev in Thread] Current Thread [Next in Thread]