[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 3/8] migration: Add spaces around operator

From: Markus Armbruster
Subject: Re: [PATCH v2 3/8] migration: Add spaces around operator
Date: Mon, 19 Oct 2020 13:59:47 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)

Bihong Yu <yubihong@huawei.com> writes:

> Yes, I used to think "const VMStateDescription *[]" was right, but when I 
> search
> similar expressions, most of all are "xxx * []". Such as:
> fsdev/qemu-fsdev.c:54:        .opts = (const char * [])
> hw/intc/s390_flic_kvm.c:567:    .subsections = (const VMStateDescription * [])
> ...

All three variations occur in the code: no space, space on both sides,
space only on the left.

> So, I keep the same style. Should I change it to "const VMStateDescription 
> *[]"?

Dropping the change to savevm.c should be fine.

Changing it to "VMStateDescription *[]" should be also fine.

I figure you can keep David's R-by in both cases.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]