[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] net: remove an assert call in eth_get_gso_type

From: P J P
Subject: [PATCH] net: remove an assert call in eth_get_gso_type
Date: Tue, 20 Oct 2020 13:41:19 +0530

From: Prasad J Pandit <pjp@fedoraproject.org>

eth_get_gso_type() routine returns segmentation offload type to use
based on L3 protocol type. It calls g_assert_not_reached if L3
protocol is unknown, making the following return statement unreachable.
Remove the g_assert call, as it maybe triggered by a guest user.

Reported-by: Gaoning Pan <pgn@zju.edu.cn>
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
 net/eth.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/net/eth.c b/net/eth.c
index 0c1d413ee2..f36a418077 100644
--- a/net/eth.c
+++ b/net/eth.c
@@ -72,9 +72,6 @@ eth_get_gso_type(uint16_t l3_proto, uint8_t *l3_hdr, uint8_t 
-    /* Unsupported offload */
-    g_assert_not_reached();
     return VIRTIO_NET_HDR_GSO_NONE | ecn_state;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]