[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] scripts/tracetool: silence SystemTap dtrace(1) long long war

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH] scripts/tracetool: silence SystemTap dtrace(1) long long warnings
Date: Tue, 20 Oct 2020 12:06:28 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1

On 10/20/20 11:40 AM, Stefan Hajnoczi wrote:
SystemTap's dtrace(1) prints the following warning when it encounters
long long arguments:

   Warning: /usr/bin/dtrace:trace/trace-dtrace-hw_virtio.dtrace:76: syntax 
error near:
   probe vhost_vdpa_dev_start

   Warning: Proceeding as if --no-pyparsing was given.

Use the uint64_t and int64_t types, respectively. This works with all
host CPU 32- and 64-bit data models (ILP32, LP64, and LLP64) that QEMU

Reported-by: Markus Armbruster <armbru@redhat.com>
Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
  scripts/tracetool/format/d.py | 6 ++++++
  1 file changed, 6 insertions(+)

diff --git a/scripts/tracetool/format/d.py b/scripts/tracetool/format/d.py
index 353722f89c..ebfb714200 100644
--- a/scripts/tracetool/format/d.py
+++ b/scripts/tracetool/format/d.py
@@ -57,6 +57,12 @@ def generate(events, backend, group):
                  # Avoid it by changing probe type to signed char * beforehand.
                  if type_ == 'int8_t *':
                      type_ = 'signed char *'
+            # SystemTap dtrace(1) emits a warning when long long is used
+            type_ = type_.replace('unsigned long long', 'uint64_t')
+            type_ = type_.replace('signed long long', 'int64_t')
+            type_ = type_.replace('long long', 'int64_t')
              if name in RESERVED_WORDS:
                  name += '_'
              args.append(type_ + ' ' + name)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]