[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v3 04/10] usb/xhci: fixup xhci kconfig deps
From: |
Sai Pavan Boddu |
Subject: |
RE: [PATCH v3 04/10] usb/xhci: fixup xhci kconfig deps |
Date: |
Tue, 20 Oct 2020 13:55:15 +0000 |
Hi,
> -----Original Message-----
> From: Gerd Hoffmann <kraxel@redhat.com>
> Sent: Tuesday, October 20, 2020 1:19 PM
> To: qemu-devel@nongnu.org
> Cc: Sergio Lopez <slp@redhat.com>; Sai Pavan Boddu <saipava@xilinx.com>;
> Igor Mammedov <imammedo@redhat.com>; Michael S. Tsirkin
> <mst@redhat.com>; Marcel Apfelbaum <marcel.apfelbaum@gmail.com>;
> Paolo Bonzini <pbonzini@redhat.com>; Thomas Huth <thuth@redhat.com>;
> Richard Henderson <rth@twiddle.net>; Gerd Hoffmann <kraxel@redhat.com>;
> Eduardo Habkost <ehabkost@redhat.com>; Laurent Vivier
> <lvivier@redhat.com>
> Subject: [PATCH v3 04/10] usb/xhci: fixup xhci kconfig deps
>
> USB_XHCI does not depend on PCI any more.
> USB_XHCI_SYSBUS must select USB_XHCI not USB.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
[Sai Pavan Boddu]
Looks clean now. I forgot to take care of this previously, this was one of our
requirements initially.
Reviewed-by: Sai Pavan Boddu <sai.pavan.boddu@xilinx.com>
Regards,
Sai Pavan
> ---
> hw/usb/Kconfig | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig index
> 4dd2ba9630cb..a674ce4c542e 100644
> --- a/hw/usb/Kconfig
> +++ b/hw/usb/Kconfig
> @@ -32,8 +32,6 @@ config USB_EHCI_SYSBUS
>
> config USB_XHCI
> bool
> - default y if PCI_DEVICES
> - depends on PCI
> select USB
>
> config USB_XHCI_PCI
> @@ -50,8 +48,8 @@ config USB_XHCI_NEC
>
> config USB_XHCI_SYSBUS
> bool
> - default y if USB_XHCI
> - select USB
> + default y
> + select USB_XHCI
>
> config USB_MUSB
> bool
> --
> 2.27.0
- [PATCH v3 00/10] microvm: add usb support, Gerd Hoffmann, 2020/10/20
- [PATCH v3 10/10] tests/acpi: update expected data files, Gerd Hoffmann, 2020/10/20
- [PATCH v3 02/10] usb/xhci: add include/hw/usb/xhci.h header file, Gerd Hoffmann, 2020/10/20
- [PATCH v3 09/10] tests/acpi: add microvm rtc test, Gerd Hoffmann, 2020/10/20
- [PATCH v3 01/10] acpi: add aml builder stubs, Gerd Hoffmann, 2020/10/20
- [PATCH v3 04/10] usb/xhci: fixup xhci kconfig deps, Gerd Hoffmann, 2020/10/20
- RE: [PATCH v3 04/10] usb/xhci: fixup xhci kconfig deps,
Sai Pavan Boddu <=
- [PATCH v3 03/10] usb/xhci: add xhci_sysbus_build_aml() helper, Gerd Hoffmann, 2020/10/20
- [PATCH v3 08/10] tests/acpi: add microvm usb test, Gerd Hoffmann, 2020/10/20
- [PATCH v3 07/10] tests/acpi: add empty tests/data/acpi/microvm/DSDT.{usb, rtc} files, Gerd Hoffmann, 2020/10/20
- [PATCH v3 06/10] tests/acpi: allow updates for expected data files, Gerd Hoffmann, 2020/10/20
- [PATCH v3 05/10] microvm: add usb support, Gerd Hoffmann, 2020/10/20