Re: [PATCH 4/4] qga: Flatten simple union GuestDeviceId

[Philippe Mathieu-Daudé]

On 10/21/20 9:15 AM, Markus Armbruster wrote:
> Simple unions are simpler than flat unions in the schema, but more
> complicated in C and on the QMP wire: there's extra indirection in C
> and extra nesting on the wire, both pointless.  They should be avoided
> in new code.
>
> GuestDeviceId was recently added for guest-get-devices.  Convert it to
> a flat union.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>   qga/qapi-schema.json | 8 ++++++++
>   qga/commands-win32.c | 9 ++++-----
>   2 files changed, 12 insertions(+), 5 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>