[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] net: remove an assert call in eth_get_gso_type
|
From: |
P J P |
|
Subject: |
Re: [PATCH v3] net: remove an assert call in eth_get_gso_type |
|
Date: |
Wed, 21 Oct 2020 14:53:33 +0530 (IST) |
+-- On Wed, 21 Oct 2020, Jason Wang wrote --+
| It should not be a guest error, since guest is allowed to send a packet
| other than IPV4(6).
* Ah...sigh! :(
* I very hesitantly used guest_error mask, since it was g_assert-ing before.
To me both guest_error and log_unimp seem mismatching. Because no GSO is
also valid IIUC. That's why in patch v2 I used plain qemu_log(). But plain
qemu_log is also not good it seems.
* I'm okay either way. Please let me know which one to use. OR I'm fine if you
fix it while merging upstream too.
Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
8685 545E B54C 486B C6EB 271E E285 8B5A F050 DE8D