[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 6/6] tests/acceptance: pick a random gdb port for reverse

From: Pavel Dovgalyuk
Subject: Re: [PATCH v1 6/6] tests/acceptance: pick a random gdb port for reverse debugging
Date: Thu, 22 Oct 2020 09:18:02 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

On 21.10.2020 19:31, Alex Bennée wrote:
Currently the test randomly fails if you are using a shared machine
due to contention on the well known port 1234. We can ameliorate this
a bit by picking a random non-ephemeral port although it doesn't
totally avoid the problem. While we could use a totally unique socket
address for debugging it's impossible to probe for gdb support of the
feature which makes this a sub-optimal but less fiddly option.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Reviewed-by: Pavel Dovgalyuk <pavel.dovgalyuk@ispras.ru>

  tests/acceptance/reverse_debugging.py | 6 ++++--
  1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/tests/acceptance/reverse_debugging.py 
index b72fdf6cdc..f2e8245471 100644
--- a/tests/acceptance/reverse_debugging.py
+++ b/tests/acceptance/reverse_debugging.py
@@ -16,6 +16,7 @@ from avocado.utils import gdb
  from avocado.utils import process
  from avocado.utils.path import find_command
  from boot_linux_console import LinuxKernelTest
+from random import randrange
class ReverseDebugging(LinuxKernelTest):
@@ -43,7 +44,8 @@ class ReverseDebugging(LinuxKernelTest):
              logger.info('replaying the execution...')
              mode = 'replay'
-            vm.add_args('-s', '-S')
+            self.port = randrange(2048, 49152)
+            vm.add_args('-gdb', 'tcp::%d' % (self.port), '-S')
          vm.add_args('-icount', 'shift=%s,rr=%s,rrfile=%s,rrsnapshot=init' %
                      (shift, mode, replay_path),
                      '-net', 'none')
@@ -122,7 +124,7 @@ class ReverseDebugging(LinuxKernelTest):
          # replay and run debug commands
          vm = self.run_vm(False, shift, args, replay_path, image_path)
          logger.info('connecting to gdbstub')
-        g = gdb.GDBRemote('', 1234, False, False)
+        g = gdb.GDBRemote('', self.port, False, False)
          r = g.cmd(b'qSupported')
          if b'qXfer:features:read+' in r:

reply via email to

[Prev in Thread] Current Thread [Next in Thread]