Re: [PATCH v2 13/20] iotests: 129: prepare for backup over block-copy

[Vladimir Sementsov-Ogievskiy]

23.07.2020 11:03, Max Reitz wrote:
> On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote:
> > After introducing parallel async copy requests instead of plain
> > cluster-by-cluster copying loop, backup job may finish earlier than
> > final assertion in do_test_stop. Let's require slow backup explicitly
> > by specifying speed parameter.
>
> Isn’t the problem really that block_set_io_throttle does absolutely
> nothing?  (Which is a long-standing problem with 129.  I personally just
> never run it, honestly.)

Hmm.. is it better to drop test_drive_backup() from here ?

> > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> > ---
> >   tests/qemu-iotests/129 | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/qemu-iotests/129 b/tests/qemu-iotests/129
> > index 4db5eca441..bca56b589d 100755
> > --- a/tests/qemu-iotests/129
> > +++ b/tests/qemu-iotests/129
> > @@ -76,7 +76,7 @@ class TestStopWithBlockJob(iotests.QMPTestCase):
> >       def test_drive_backup(self):
> >           self.do_test_stop("drive-backup", device="drive0",
> >                             target=self.target_img,
> > -                          sync="full")
> > +                          sync="full", speed=1024)
> >   
> >       def test_block_commit(self):
> >           self.do_test_stop("block-commit", device="drive0")


--
Best regards,
Vladimir