[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 1/3] accel: Remove _WIN32 ifdef from qtest-cpus.c

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 1/3] accel: Remove _WIN32 ifdef from qtest-cpus.c
Date: Fri, 23 Oct 2020 10:04:20 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1

On 10/13/20 4:05 PM, Jason Andryuk wrote:
dummy-cpus.c is only compiled with CONFIG_POSIX, so the _WIN32 condition
will never evaluate true.  Remove it.

I disagree with this removal, as you are making this a generic
accelerator out of QTest. I'd rather keep this and replace the
error message with "Dummy accelerator is not supported on
Windows" and not make it POSIX-specific. As Paolo already acked
this patch so I am not objecting to it.

Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
v2: New in v2
  accel/qtest/qtest-cpus.c | 5 -----
  1 file changed, 5 deletions(-)

diff --git a/accel/qtest/qtest-cpus.c b/accel/qtest/qtest-cpus.c
index 7c5399ed9d..db094201c1 100644
--- a/accel/qtest/qtest-cpus.c
+++ b/accel/qtest/qtest-cpus.c
@@ -29,10 +29,6 @@
static void *qtest_cpu_thread_fn(void *arg)
-#ifdef _WIN32
-    error_report("qtest is not supported under Windows");
-    exit(1);
      CPUState *cpu = arg;
      sigset_t waitset;
      int r;
@@ -69,7 +65,6 @@ static void *qtest_cpu_thread_fn(void *arg)
      return NULL;
static void qtest_start_vcpu_thread(CPUState *cpu)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]