[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH RESEND v3 09/10] pci: Let pci_dma_read() propagate MemTxResult
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH RESEND v3 09/10] pci: Let pci_dma_read() propagate MemTxResult |
Date: |
Fri, 23 Oct 2020 17:19:22 +0200 |
pci_dma_rw() returns a MemTxResult type.
Do not discard it, return it to the caller.
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
include/hw/pci/pci.h | 16 ++++++++++++++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
index b8780ea18c1..85b5786a5da 100644
--- a/include/hw/pci/pci.h
+++ b/include/hw/pci/pci.h
@@ -800,8 +800,20 @@ static inline MemTxResult pci_dma_rw(PCIDevice *dev,
dma_addr_t addr,
return dma_memory_rw(pci_get_address_space(dev), addr, buf, len, dir);
}
-static inline int pci_dma_read(PCIDevice *dev, dma_addr_t addr,
- void *buf, dma_addr_t len)
+/**
+ * pci_dma_read: Read from an address space from PCI device.
+ *
+ * Return a MemTxResult indicating whether the operation succeeded
+ * or failed (eg unassigned memory, device rejected the transaction,
+ * IOMMU fault). Called within RCU critical section.
+ *
+ * @dev: #PCIDevice doing the memory access
+ * @addr: address within the #PCIDevice address space
+ * @buf: buffer with the data transferred
+ * @len: length of the data transferred
+ */
+static inline MemTxResult pci_dma_read(PCIDevice *dev, dma_addr_t addr,
+ void *buf, dma_addr_t len)
{
return pci_dma_rw(dev, addr, buf, len, DMA_DIRECTION_TO_DEVICE);
}
--
2.26.2
- [PATCH RESEND v3 00/10] hw: Let DMA/PCI API propagate MemTxResult, Philippe Mathieu-Daudé, 2020/10/23
- [PATCH RESEND v3 01/10] pci: pass along the return value of dma_memory_rw, Philippe Mathieu-Daudé, 2020/10/23
- [PATCH RESEND v3 02/10] docs/devel/loads-stores: Add regexp for DMA functions, Philippe Mathieu-Daudé, 2020/10/23
- [PATCH RESEND v3 03/10] dma: Document address_space_map/address_space_unmap() prototypes, Philippe Mathieu-Daudé, 2020/10/23
- [PATCH RESEND v3 04/10] dma: Let dma_memory_set() propagate MemTxResult, Philippe Mathieu-Daudé, 2020/10/23
- [PATCH RESEND v3 05/10] dma: Let dma_memory_rw() propagate MemTxResult, Philippe Mathieu-Daudé, 2020/10/23
- [PATCH RESEND v3 06/10] dma: Let dma_memory_read() propagate MemTxResult, Philippe Mathieu-Daudé, 2020/10/23
- [PATCH RESEND v3 07/10] dma: Let dma_memory_write() propagate MemTxResult, Philippe Mathieu-Daudé, 2020/10/23
- [PATCH RESEND v3 08/10] pci: Let pci_dma_rw() propagate MemTxResult, Philippe Mathieu-Daudé, 2020/10/23
- [PATCH RESEND v3 09/10] pci: Let pci_dma_read() propagate MemTxResult,
Philippe Mathieu-Daudé <=
- [PATCH RESEND v3 10/10] pci: Let pci_dma_write() propagate MemTxResult, Philippe Mathieu-Daudé, 2020/10/23
- Re: [PATCH RESEND v3 00/10] hw: Let DMA/PCI API propagate MemTxResult, Philippe Mathieu-Daudé, 2020/10/23