[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 01/12] libqos/qgraph: add qemu_name to QOSGraphNode

From: Thomas Huth
Subject: Re: [PATCH v4 01/12] libqos/qgraph: add qemu_name to QOSGraphNode
Date: Sat, 24 Oct 2020 08:08:59 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0

On 19/10/2020 12.35, Christian Schoenebeck wrote:
> On Donnerstag, 8. Oktober 2020 20:34:56 CEST Christian Schoenebeck wrote:
>> Add new member variable 'qemu_name' to struct QOSGraphNode.
>> This new member may be optionally set in case a different
>> name for the node (which must always be a unique name) vs.
>> its actually associated QEMU (QMP) device name is required.
>> Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
>> ---
>>  tests/qtest/libqos/qgraph.c          | 1 +
>>  tests/qtest/libqos/qgraph_internal.h | 1 +
>>  2 files changed, 2 insertions(+)
> So what shall happen with these libqos patches 1..7? Is that a nack, or 
> postpone for now?

I was hoping to see a review by Paolo or Laurent, who are much more familiar
with qos than I am ... but after having a look at the patches, I think I can
also give some feedback, too:

Patch 1 and 2 sound basically ok to me (should maybe be squashed together,
though), but the qos_node_create_driver_named() function currently seems to
be unused so far? So I'd postpone these two patches to the point in time
when you really need the qos_node_create_driver_named() function.

The other patches are basically fine with me, too, but please avoid the
hard-coded ESC codes that only work with certain terminals.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]