Re: [PATCH] tests/acceptance: expand Orange Pi PC SD images for NetBSD, Armbian above nearest power of two

[Bin Meng]

On Sun, Oct 25, 2020 at 8:13 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> On 10/25/20 2:31 AM, Philippe Mathieu-Daudé wrote:
> > Hi Niek,
> >
> > On 10/24/20 11:52 PM, Niek Linnenbank wrote:
> >> The acceptance tests for the Orange Pi PC need to expand the SD card
> >> images
> >> to a size which is a power of two. As Qemu uses the size of the SD
> >> image file
> >> as well for the size of the emulated SD card, this can sometimes give
> >> problems
> >> for guests that assume a certain minimum size of the SD card.
> >>
> >> This commit resolves the following acceptance test error for the
> >> NetBSD 9.0 test
> >> of the Orange Pi PC by increasing the size of the expanded SD card
> >> image to two times
> >> the nearest power of two:
> >>
> >>     (5/5)
> >> tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_orangepi_uboot_netbsd9:
> >> |console: U-Boot SPL 2020.01+dfsg-1 (Jan 08 2020 - 08:19:44 +0000)
> >>    console: DRAM: 1024 MiB
> >>    console: Failed to set core voltage! Can't set CPU frequency
> >>    /console: Trying to boot from MMC1
> >>    console: U-Boot 2020.01+dfsg-1 (Jan 08 2020 - 08:19:44 +0000)
> >> Allwinner Technology
> >>    ...
> >>    console: Starting kernel ...
> >>    console: [   1.0000000] NetBSD/evbarm (fdt) booting ...
> >>    ...
> >>    console: [   1.3300167] sdmmc0: SD card status: 4-bit, C0
> >>    console: [   1.3300167] ld0 at sdmmc0:
> >> <0xaa:0x5859:QEMU!:0x01:0xdeadbeef:0x062>
> >
> > The test has this comment:
> >
> >     # This test download a 304MB compressed image and expand it to 2GB
> >
> > Once uncompressed the image is ~1.2GB before rounding to 2GB.
> >
> >>    console: [   1.3430678] ld0: 1024 MB, 1040 cyl, 32 head, 63 sec,
> >> 512 bytes/sect x 2097152 sectors
> >
> > Why the card appears as 1GB??     ^^^^^^^
> >
> > Can you try reverting commit 6d2d4069c47?
> > ("sd: Correct the maximum size of a Standard Capacity SD Memory Card")
>
> Now I remember, I hit the similar problem 2 years ago :S
>
> See the description of the C_SIZE field in CSD register:
>
>    "To indicate 2 GByte card, BLOCK_LEN shall be 1024 bytes."

Ah, yes! 2 GiB is special in the spec. Thanks Philippe!

>
> This model uses a fixed BLOCK_LEN = 512 bytes.
>

Niek, could you please try the following patch?
20201025152357.11865-1-bmeng.cn@gmail.com/">http://patchwork.ozlabs.org/project/qemu-devel/patch/20201025152357.11865-1-bmeng.cn@gmail.com/

Regards,
Bin