[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/9] dev-serial: use USB_SERIAL QOM macro for USBSerialState
From: |
Samuel Thibault |
Subject: |
Re: [PATCH 2/9] dev-serial: use USB_SERIAL QOM macro for USBSerialState assignments |
Date: |
Mon, 26 Oct 2020 10:37:29 +0100 |
User-agent: |
NeoMutt/20170609 (1.8.3) |
Mark Cave-Ayland, le lun. 26 oct. 2020 08:33:54 +0000, a ecrit:
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
> hw/usb/dev-serial.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/usb/dev-serial.c b/hw/usb/dev-serial.c
> index 7a5fa3770e..77ce89d38b 100644
> --- a/hw/usb/dev-serial.c
> +++ b/hw/usb/dev-serial.c
> @@ -204,7 +204,7 @@ static void usb_serial_reset(USBSerialState *s)
>
> static void usb_serial_handle_reset(USBDevice *dev)
> {
> - USBSerialState *s = (USBSerialState *)dev;
> + USBSerialState *s = USB_SERIAL(dev);
>
> DPRINTF("Reset\n");
>
> @@ -243,7 +243,7 @@ static void usb_serial_handle_control(USBDevice *dev,
> USBPacket *p,
> int request, int value, int index,
> int length, uint8_t *data)
> {
> - USBSerialState *s = (USBSerialState *)dev;
> + USBSerialState *s = USB_SERIAL(dev);
> int ret;
>
> DPRINTF("got control %x, value %x\n", request, value);
> @@ -430,7 +430,7 @@ static void usb_serial_token_in(USBSerialState *s,
> USBPacket *p)
>
> static void usb_serial_handle_data(USBDevice *dev, USBPacket *p)
> {
> - USBSerialState *s = (USBSerialState *)dev;
> + USBSerialState *s = USB_SERIAL(dev);
> uint8_t devep = p->ep->nr;
> struct iovec *iov;
> int i;
> --
> 2.20.1
>
--
Samuel
<h> t: bah c'est tendre le pattern pour se faire matcher, hein
- [PATCH 0/9] dev-serial: minor fixes and improvements, Mark Cave-Ayland, 2020/10/26
- [PATCH 1/9] dev-serial: style changes to improve readability and checkpatch fixes, Mark Cave-Ayland, 2020/10/26
- [PATCH 2/9] dev-serial: use USB_SERIAL QOM macro for USBSerialState assignments, Mark Cave-Ayland, 2020/10/26
- [PATCH 3/9] dev-serial: convert from DPRINTF to trace-events, Mark Cave-Ayland, 2020/10/26
- [PATCH 4/9] dev-serial: add trace-events for baud rate and data parameters, Mark Cave-Ayland, 2020/10/26
- [PATCH 5/9] dev-serial: replace DeviceOutVendor/DeviceInVendor with equivalent macros from usb.h, Mark Cave-Ayland, 2020/10/26