[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v29 05/17] vfio: Add VM state change handler to know state of
From: |
Alex Williamson |
Subject: |
Re: [PATCH v29 05/17] vfio: Add VM state change handler to know state of VM |
Date: |
Mon, 26 Oct 2020 07:00:56 -0600 |
On Mon, 26 Oct 2020 15:06:15 +0530
Kirti Wankhede <kwankhede@nvidia.com> wrote:
> VM state change handler is called on change in VM's state. Based on
> VM state, VFIO device state should be changed.
> Added read/write helper functions for migration region.
> Added function to set device_state.
>
> Signed-off-by: Kirti Wankhede <kwankhede@nvidia.com>
> Reviewed-by: Neo Jia <cjia@nvidia.com>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
> ---
> hw/vfio/migration.c | 158
> ++++++++++++++++++++++++++++++++++++++++++
> hw/vfio/trace-events | 2 +
> include/hw/vfio/vfio-common.h | 4 ++
> 3 files changed, 164 insertions(+)
>
> diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c
> index fd7faf423cdc..65ce735d667b 100644
> --- a/hw/vfio/migration.c
> +++ b/hw/vfio/migration.c
[snip]
> @@ -64,6 +216,9 @@ static int vfio_migration_init(VFIODevice *vbasedev,
> ret = -EINVAL;
> goto err;
> }
> +
> + migration->vm_state =
> qemu_add_vm_change_state_handler(vfio_vmstate_change,
> + vbasedev);
> return 0;
>
> err:
Fails to build, @migration is not defined. We could use
vbasedev->migration or pull defining and setting @migration from patch
06. Thanks,
Alex
- [PATCH v29 00/17] Add migration support for VFIO devices, Kirti Wankhede, 2020/10/26
- [PATCH v29 01/17] vfio: Add function to unmap VFIO region, Kirti Wankhede, 2020/10/26
- [PATCH v29 02/17] vfio: Add vfio_get_object callback to VFIODeviceOps, Kirti Wankhede, 2020/10/26
- [PATCH v29 03/17] vfio: Add save and load functions for VFIO PCI devices, Kirti Wankhede, 2020/10/26
- [PATCH v29 04/17] vfio: Add migration region initialization and finalize function, Kirti Wankhede, 2020/10/26
- [PATCH v29 05/17] vfio: Add VM state change handler to know state of VM, Kirti Wankhede, 2020/10/26
- Re: [PATCH v29 05/17] vfio: Add VM state change handler to know state of VM,
Alex Williamson <=
[PATCH v29 06/17] vfio: Add migration state change notifier, Kirti Wankhede, 2020/10/26
[PATCH v29 07/17] vfio: Register SaveVMHandlers for VFIO device, Kirti Wankhede, 2020/10/26
[PATCH v29 08/17] vfio: Add save state functions to SaveVMHandlers, Kirti Wankhede, 2020/10/26
[PATCH v29 09/17] vfio: Add load state functions to SaveVMHandlers, Kirti Wankhede, 2020/10/26
[PATCH v29 10/17] memory: Set DIRTY_MEMORY_MIGRATION when IOMMU is enabled, Kirti Wankhede, 2020/10/26