Re: [PATCH 2/3] console: modify ppm_save to take a pixman image ref

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/3] console: modify ppm_save to take a pixman image ref

From:	Markus Armbruster
Subject:	Re: [PATCH 2/3] console: modify ppm_save to take a pixman image ref
Date:	Tue, 27 Oct 2020 08:27:28 +0100
User-agent:	Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)

marcandre.lureau@redhat.com writes:

> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> The function is going to be called from a coroutine, and may yields.

s/yields/yield/

> Let's ensure our image reference doesn't change over time (due to resize
> etc) by keeping a ref.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Reviewed-by: Markus Armbruster <armbru@redhat.com>

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 0/3] console: make QMP screendump use coroutine, marcandre . lureau, 2020/10/10
- [PATCH 1/3] coroutine: let CoQueue wake up outside a coroutine, marcandre . lureau, 2020/10/10
  - Re: [PATCH 1/3] coroutine: let CoQueue wake up outside a coroutine, Markus Armbruster, 2020/10/27
  - Re: [PATCH 1/3] coroutine: let CoQueue wake up outside a coroutine, Kevin Wolf, 2020/10/27
- [PATCH 2/3] console: modify ppm_save to take a pixman image ref, marcandre . lureau, 2020/10/10
  - Re: [PATCH 2/3] console: modify ppm_save to take a pixman image ref, Markus Armbruster <=
- [PATCH 3/3] console: make QMP/HMP screendump run in coroutine, marcandre . lureau, 2020/10/10
  - Re: [PATCH 3/3] console: make QMP/HMP screendump run in coroutine, Markus Armbruster, 2020/10/27
    - Re: [PATCH 3/3] console: make QMP/HMP screendump run in coroutine, Marc-André Lureau, 2020/10/27
    - Re: [PATCH 3/3] console: make QMP/HMP screendump run in coroutine, Markus Armbruster, 2020/10/27
- Re: [PATCH 0/3] console: make QMP screendump use coroutine, Gerd Hoffmann, 2020/10/13
- Re: [PATCH 0/3] console: make QMP screendump use coroutine, Markus Armbruster, 2020/10/27

Prev by Date: [Bug 1897194] Re: Test failure in test-crypto-secret.c
Next by Date: Re: [PATCH 1/4] spapr: qemu_memalign() doesn't return NULL
Previous by thread: [PATCH 2/3] console: modify ppm_save to take a pixman image ref
Next by thread: [PATCH 3/3] console: make QMP/HMP screendump run in coroutine
Index(es):
- Date
- Thread