|
From: | Paolo Bonzini |
Subject: | Re: [PATCH 07/15] m68k: remove bios_name |
Date: | Tue, 27 Oct 2020 14:26:44 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 |
On 26/10/20 20:11, Laurent Vivier wrote: >> /* Load kernel. */ >> if (!kernel_filename) { >> - if (qtest_enabled() || bios_name) { >> + if (qtest_enabled() || machine->firmware) { >> return; >> } >> error_report("Kernel image must be specified"); > Why do you do differently for mcf5208 than the others? > > const char *bios_name = machine->firmware; > > and no other changes? because in this case you can use machine->firmware, I'm keeping bios_name for the cases where machine->firmware cannot be used directly (e.g. there is a default). Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |