[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 05/12] contrib/vhost-user-blk: fix get_config() information leak
From: |
Stefan Hajnoczi |
Subject: |
[PATCH 05/12] contrib/vhost-user-blk: fix get_config() information leak |
Date: |
Tue, 27 Oct 2020 17:35:21 +0000 |
Refuse get_config() in excess of sizeof(struct virtio_blk_config).
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
contrib/vhost-user-blk/vhost-user-blk.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/contrib/vhost-user-blk/vhost-user-blk.c
b/contrib/vhost-user-blk/vhost-user-blk.c
index 25eccd02b5..caad88637e 100644
--- a/contrib/vhost-user-blk/vhost-user-blk.c
+++ b/contrib/vhost-user-blk/vhost-user-blk.c
@@ -404,6 +404,8 @@ vub_get_config(VuDev *vu_dev, uint8_t *config, uint32_t len)
VugDev *gdev;
VubDev *vdev_blk;
+ g_return_val_if_fail(len <= sizeof(struct virtio_blk_config), -1);
+
gdev = container_of(vu_dev, VugDev, parent);
vdev_blk = container_of(gdev, VubDev, parent);
memcpy(config, &vdev_blk->blkcfg, len);
--
2.26.2
- [PATCH 00/12] block/export: vhost-user-blk server cleanups and tests, Stefan Hajnoczi, 2020/10/27
- [PATCH 01/12] libvhost-user: follow QEMU comment style, Stefan Hajnoczi, 2020/10/27
- [PATCH 02/12] configure: introduce --enable-vhost-user-blk-server, Stefan Hajnoczi, 2020/10/27
- [PATCH 03/12] block/export: make vhost-user-blk config space little-endian, Stefan Hajnoczi, 2020/10/27
- [PATCH 05/12] contrib/vhost-user-blk: fix get_config() information leak,
Stefan Hajnoczi <=
- [PATCH 04/12] block/export: fix vhost-user-blk get_config() information leak, Stefan Hajnoczi, 2020/10/27
- [PATCH 07/12] tests/qtest: add multi-queue test case to vhost-user-blk-test, Stefan Hajnoczi, 2020/10/27
- [PATCH 10/12] vhost-user-blk-test: close fork child file descriptors, Stefan Hajnoczi, 2020/10/27
- [PATCH 09/12] vhost-user-blk-test: rename destroy_drive() to destroy_file(), Stefan Hajnoczi, 2020/10/27
- [PATCH 06/12] test: new qTest case to test the vhost-user-blk-server, Stefan Hajnoczi, 2020/10/27
- [PATCH 08/12] libqtest: add qtest_socket_server(), Stefan Hajnoczi, 2020/10/27
- [PATCH 12/12] vhost-user-blk-test: fix races by using fd passing, Stefan Hajnoczi, 2020/10/27
- [PATCH 11/12] vhost-user-blk-test: drop unused return value, Stefan Hajnoczi, 2020/10/27
- Re: [PATCH 00/12] block/export: vhost-user-blk server cleanups and tests, Michael S. Tsirkin, 2020/10/30