[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 09/10] hw/pci-host/sabre: Remove superfluous address range check
From: |
Mark Cave-Ayland |
Subject: |
[PULL 09/10] hw/pci-host/sabre: Remove superfluous address range check |
Date: |
Wed, 28 Oct 2020 08:23:57 +0000 |
From: Philippe Mathieu-Daudé <f4bug@amsat.org>
The region is registered as 64KiB in sabre_init():
memory_region_init_io(&s->sabre_config, OBJECT(s), &sabre_config_ops, s,
"sabre-config", 0x10000);
Remove the superfluous check.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Message-Id: <20201012170950.3491912-3-f4bug@amsat.org>
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
---
hw/pci-host/sabre.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/pci-host/sabre.c b/hw/pci-host/sabre.c
index 0ee247e28f..f678a3eefc 100644
--- a/hw/pci-host/sabre.c
+++ b/hw/pci-host/sabre.c
@@ -120,7 +120,7 @@ static void sabre_config_write(void *opaque, hwaddr addr,
trace_sabre_config_write(addr, val);
- switch (addr & 0xffff) {
+ switch (addr) {
case 0x30 ... 0x4f: /* DMA error registers */
/* XXX: not implemented yet */
break;
@@ -197,7 +197,7 @@ static uint64_t sabre_config_read(void *opaque,
SabreState *s = opaque;
uint32_t val;
- switch (addr & 0xffff) {
+ switch (addr) {
case 0x30 ... 0x4f: /* DMA error registers */
val = 0;
/* XXX: not implemented yet */
--
2.20.1
- [PULL 00/10] qemu-sparc queue 20201028, Mark Cave-Ayland, 2020/10/28
- [PULL 01/10] sparc32-dma: use object_initialize_child() for espdma and ledma child objects, Mark Cave-Ayland, 2020/10/28
- [PULL 02/10] sparc32-ledma: use object_initialize_child() for lance child object, Mark Cave-Ayland, 2020/10/28
- [PULL 03/10] sparc32-espdma: use object_initialize_child() for esp child object, Mark Cave-Ayland, 2020/10/28
- [PULL 04/10] sparc32-ledma: don't reference nd_table directly within the device, Mark Cave-Ayland, 2020/10/28
- [PULL 05/10] sabre: don't call sysbus_mmio_map() in sabre_realize(), Mark Cave-Ayland, 2020/10/28
- [PULL 06/10] hw/display/tcx: Allow 64-bit accesses to framebuffer stippler and blitter, Mark Cave-Ayland, 2020/10/28
- [PULL 07/10] sabre: increase number of PCI bus IRQs from 32 to 64, Mark Cave-Ayland, 2020/10/28
- [PULL 08/10] hw/pci-host/sabre: Update documentation link, Mark Cave-Ayland, 2020/10/28
- [PULL 09/10] hw/pci-host/sabre: Remove superfluous address range check,
Mark Cave-Ayland <=
- [PULL 10/10] hw/pci-host/sabre: Simplify code initializing variable once, Mark Cave-Ayland, 2020/10/28
- Re: [PULL 00/10] qemu-sparc queue 20201028, Peter Maydell, 2020/10/31