[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 14/15] python/qemu: add isort to pipenv

From: John Snow
Subject: Re: [PATCH v3 14/15] python/qemu: add isort to pipenv
Date: Wed, 28 Oct 2020 20:07:41 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1

On 10/28/20 6:46 PM, Cleber Rosa wrote:
On Tue, Oct 20, 2020 at 03:35:54PM -0400, John Snow wrote:
isort 5.0.0 through 5.0.4 has a bug that causes it to misinterpret
certain "from ..." clauses that are not related to imports.

Require 5.0.5 or greater.

isort can be run with 'isort -c qemu' from the python root.

Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Reviewed-by: Cleber Rosa <crosa@redhat.com>
Tested-by: Cleber Rosa <crosa@redhat.com>

Good suggestion on isort, btw. I was afraid at first it was going to be annoying to integrate a fourth tool, but it wound up sliding in very nicely as you can see. :)

I like the effect it has already had on these and the QAPI patches.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]