[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 10/11] sockets: Bypass "replace empty @path" for abstract uni
From: |
Eric Blake |
Subject: |
Re: [PATCH 10/11] sockets: Bypass "replace empty @path" for abstract unix sockets |
Date: |
Thu, 29 Oct 2020 14:42:38 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 |
On 10/29/20 8:38 AM, Markus Armbruster wrote:
> unix_listen_saddr() replaces empty @path by unique value. It obtains
> the value by creating and deleting a unique temporary file with
> mkstemp(). This is racy, as the comment explains. It's also entirely
> undocumented as far as I can tell. Goes back to commit d247d25f18
> "sockets: helper functions for qemu (Gerd Hoffman)", v0.10.0.
>
> Since abstract socket addresses have no connection with filesystem
> pathnames, making them up with mkstemp() seems inappropriate. Bypass
> the replacement of empty @path.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> util/qemu-sockets.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
> diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
> index 801c5e3957..18c8de8cdb 100644
> --- a/util/qemu-sockets.c
> +++ b/util/qemu-sockets.c
> @@ -871,7 +871,7 @@ static int unix_listen_saddr(UnixSocketAddress *saddr,
> return -1;
> }
>
> - if (saddr->path && saddr->path[0]) {
> + if (saddr->path[0] || saddr->abstract) {
> path = saddr->path;
> } else {
> const char *tmpdir = getenv("TMPDIR");
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
- [PATCH 07/11] sockets: Fix default of UnixSocketAddress member @tight, (continued)
- [PATCH 06/11] test-util-sockets: Test the complete abstract socket matrix, Markus Armbruster, 2020/10/29
- [PATCH 10/11] sockets: Bypass "replace empty @path" for abstract unix sockets, Markus Armbruster, 2020/10/29
- Re: [PATCH 10/11] sockets: Bypass "replace empty @path" for abstract unix sockets,
Eric Blake <=
- [PATCH 11/11] sockets: Make abstract UnixSocketAddress depend on CONFIG_LINUX, Markus Armbruster, 2020/10/29
- Re: [PATCH 00/11] sockets: Attempt to drain the abstract socket swamp, Marc-André Lureau, 2020/10/29
- Re: [PATCH 00/11] sockets: Attempt to drain the abstract socket swamp, Paolo Bonzini, 2020/10/29